Page MenuHomePhabricator
Create Task
Maniphest T217382

APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: XHhSqgpAMEQAAH7N4bYAAADG

message
PHP Warning: Invalid operand type was used: Invalid type used as key
/srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiBase.php:1808
trace
#0 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiBase.php(1808): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiBase.php(2146): ApiBase->errorArrayToStatus(array, User)
#2 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiEditPage.php(121): ApiBase->checkTitleUserPermissions(Title, string, array)
#3 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiMain.php(1596): ApiEditPage->execute()
#4 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.33.0-wmf.19/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.33.0-wmf.19/api.php(87): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include(string)
#8 {main}

Impact

Notes

Spotted on itwiki and metawiki

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
API: Handle Messages in errorArrayToStatus()mediawiki/corewmf/1.33.0-wmf.19+23 -2
API: Handle Messages in errorArrayToStatus()mediawiki/coremaster+23 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Feb 28 2019, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2019, 9:54 PM
greg moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.Mar 1 2019, 2:24 AM
Anomie claimed this task.Mar 1 2019, 2:40 PM
Anomie subscribed.

Hmm, probably somehow we're getting an array where the first element is a Message object there. I'll add a check for that.

gerritbot subscribed.Mar 1 2019, 2:58 PM

Change 493700 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Handle Messages in errorArrayToStatus()

https://gerrit.wikimedia.org/r/493700

gerritbot added a project: Patch-For-Review.Mar 1 2019, 2:58 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Mar 1 2019, 2:59 PM
Anomie added a project: Platform Team Workboards (Waiting for Review).
gerritbot added a comment.Mar 4 2019, 5:24 AM

Change 493700 merged by jenkins-bot:
[mediawiki/core@master] API: Handle Messages in errorArrayToStatus()

https://gerrit.wikimedia.org/r/493700

Anomie closed this task as Resolved.Mar 4 2019, 8:34 PM

Feel free to backport if riding the train this week isn't fast enough. Since this wasn't UBN I'm guessing it's not that common.

Catrope mentioned this in T217615: Invalid operand type was used: Invalid type used as key in ApiBase.php.Mar 5 2019, 2:25 AM
Catrope merged a task: T217615: Invalid operand type was used: Invalid type used as key in ApiBase.php.
Catrope added subscribers: Catrope, Stashbot.

This rose in frequency today because someone has been repeatedly attempting to create a page on mswiki and tripping the TitleBlacklist entry about Armenian characters. Details in T217615: Invalid operand type was used: Invalid type used as key in ApiBase.php.

gerritbot added a comment.Mar 5 2019, 2:28 AM

Change 494401 had a related patch set uploaded (by Catrope; owner: Anomie):
[mediawiki/core@wmf/1.33.0-wmf.19] API: Handle Messages in errorArrayToStatus()

https://gerrit.wikimedia.org/r/494401

gerritbot added a comment.Mar 5 2019, 2:42 AM

Change 494401 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.19] API: Handle Messages in errorArrayToStatus()

https://gerrit.wikimedia.org/r/494401

Stashbot added a comment.Mar 5 2019, 3:05 AM

Mentioned in SAL (#wikimedia-operations) [2019-03-05T03:05:00Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.19/includes/api/ApiBase.php: Handle TitleBlacklist errors correctly (T217382) (duration: 00m 49s)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 4:01 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.19; 2019-02-26); removed MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 5:04 PM
• CCicalese_WMF moved this task from Waiting for Review to Done with CPT on the Platform Team Workboards board.Mar 12 2019, 2:44 PM
• CCicalese_WMF edited projects, added Platform Team Workboards (Done with CPT); removed Platform Team Workboards (Waiting for Review).
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:14 PM
Krinkle moved this task from Nov2019/1.35.wmf.5+ to Older on the Wikimedia-production-error board.Nov 7 2019, 7:49 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits