Page MenuHomePhabricator

Use a 4th constant in rc_patrolled for unpatrollable log entries and categorization changes
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/428728/, it has been suggested that rc_patrolled should not be 1 or 2 for unpatrollable log entries (most of them, except for upload entries) and categorization changes. Perhaps, it should be a 4th constant, "PRC_UNPATROLLABLE = 3". We also need to make RCFilters and the API use this 4th constant. I have abandoned my patch for this so that someone else can make a patch.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I would appreciate @Catrope's thoughts here but in general, after defining autopatrol state in RC, we had to add lots of bits to the API to handle it properly. See T184791: Make rc_patrolled 3-state instead of 2-state to distinguish autopatrolled edits. It's not as easy as adding just one more state.

Krinkle claimed this task.

Boldingly closing since T184791 has since been resolved which seems to address the same underlying issue, even if approached slightly differently.