Remove altitude from JSON output about globecoordinate values
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Lucas_Werkmeister_WMDE
	Mar 1 2019, 6:18 PM

Description

There is an altitude field in the array representation for globe coordinate values that is always null. According to @JeroenDeDauw (quoted in T177269#3685706), it was never used; [GlobeCoordinateValue::getArrayValue()](https://github.com/DataValues/Geo/blob/3.0.1/src/Values/GlobeCoordinateValue.php#L193-L195) now always sets it to null, and the JSON datamodel documentation has described it as “deprecated and no longer used” since its first revision on MediaWiki.org. Let’s just get rid of it and save a few bytes in the database, in the dumps and in Special:EntityData responses.

(Of course, this is technically a breaking change that should be properly announced.)

Related Objects

Mentioned In: T230117: Remove type: statement from JSON serialization of statements
Mentioned Here: T177269: Is `altitude` in `globe-coordinate` still in use?

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 1 2019, 6:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2019, 6:18 PM

And yes, we really write this thing to the database:

> var_dump( WikiPage::factory( Title::newFromText( 'Q183' ) )->getContent()->getNativeData()['claims']['P625'][0]['mainsnak']['datavalue']['value'] );                      
array(5) {
  ["latitude"]=>
  float(51)
  ["longitude"]=>
  float(10)
  ["altitude"]=>
  NULL
  ["precision"]=>
  int(1)
  ["globe"]=>
  string(33) "http://www.wikidata.org/entity/Q2"
}

Lucas_Werkmeister_WMDE mentioned this in T230117: Remove type: statement from JSON serialization of statements.Aug 8 2019, 11:28 AM

Remove altitude from JSON output about globecoordinate valuesOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Remove altitude from JSON output about globecoordinate values
Open, Needs TriagePublic
Actions