Page MenuHomePhabricator

Next article text is visible on randomizer
Closed, ResolvedPublic

Assigned To
Authored By
ABorbaWMF
Mar 1 2019, 8:52 PM
Referenced Files
F28386503: eaf-03.png
Mar 14 2019, 10:49 AM
F28386265: image.png
Mar 14 2019, 10:16 AM
F28384406: Screenshot_1552520951.png
Mar 13 2019, 11:52 PM
F28384399: Screenshot_1552520791.png
Mar 13 2019, 11:52 PM
F28312968: Screenshot_20190301-124535.png
Mar 1 2019, 8:52 PM
F28312967: Screenshot_20190301-124527.png
Mar 1 2019, 8:52 PM

Description

2.7.0-beta-2019-02-26

Steps:

  1. Launch randomizer
  2. Orient the device in landscape mode

Expected Result:
Not sure, but one cannot see the text of the 'next' card when in portrait mode

Actual Result:
The text near the bottom of the next card is visible

Screenshot_20190301-124527.png (1×1 px, 573 KB)

Screenshot_20190301-124535.png (1×1 px, 751 KB)

Event Timeline

Looks like it also relates to the ticket. In the current design of the Suggested edits, the text in next card will be seen sometimes.

Screenshot_1552520791.png (2×1 px, 208 KB)

I am not sure how we are going to improve it. @schoenbaechler and cc @Charlotte

Hide the text until we actually on the card? or using a placeholder image like what we have already done in the Tabs

Screenshot_1552520951.png (2×1 px, 267 KB)

Hey @cooltey, thanks for these details. I suggest to not preview the underlying card at all, as shown in the designs, e.g. here:

eaf-03.png (1×720 px, 644 KB)
eaf-03 on Zeplin

The elevation, in the form of the shadow, is enough to tell user that there’s an element underneath it.


Oh, btw., the card behavior as described in T217170 should be:

Show more of article text based on the users screen height. The more content from the article, the better (more context for users). The minimum article text that should be shown is 3 lines.

Here’s a closeup from (from Zeplin):

image.png (1×2 px, 620 KB)

Ideally, the card height stretches to show more text of the article and always has a 48dp margin-bottom to the next element (shuffle/dice button). Does that have an impact on this situation (at least in “Suggested edits“)? (CC: @Sharvaniharan)

Agree with @schoenbaechler that we don't need to preview the next card. @Dbrant mentioned in our last planning session there might be a way to stretch the card height to show as much of the article as the user's screen has room for. This would greatly improve matters I think.

I see, thanks for the responses, @schoenbaechler and @Charlotte !

Ideally, the card height stretches to show more text of the article and always has a 48dp margin-bottom to the next element (shuffle/dice button). Does that have an impact on this situation (at least in “Suggested edits“)? (CC: @Sharvaniharan)

Will do that in the patch of T217170