Page MenuHomePhabricator

Remove checks for PHP modules that core already requires
Closed, ResolvedPublic

Description

	/**
	 * @return Status
	 */
	public static function verifyFinfoExists() {
		if ( !class_exists( 'finfo' ) ) {
			return Status::newFatal( 'gwtoolset-verify-finfo', Constants::EXTENSION_NAME );
		}

		return Status::newGood();
	}

	/**
	 * @return Status
	 */
	public static function verifyXMLReaderExists() {
		if ( !class_exists( 'XMLReader' ) ) {
			return Status::newFatal( 'gwtoolset-verify-xmlreader', Constants::EXTENSION_NAME );
		}

		return Status::newGood();
	}

This code should be removed, the messages removed from en.json and qqq.json

MW Core already requires ext-fileinfo and ext-xml, so no replacement is needed as these are superfluous

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ammarpad reopened this task as Open.
Ammarpad triaged this task as Medium priority.

Change 495257 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/GWToolset@master] Remove chcks for PHP modules that core already requires

https://gerrit.wikimedia.org/r/495257

Change 495257 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Remove checks for PHP modules that core already requires

https://gerrit.wikimedia.org/r/495257

Reedy removed a project: Patch-For-Review.