Page MenuHomePhabricator
Create Task
Maniphest T217545

Update selenium-daily-beta-* jobs to node10/npm6
Closed, ResolvedPublic
Actions

Description

The jobs have to be switched to node10. Also they currently use docker-registry.wikimedia.org/releng/npm-browser-test:0.4.0 which is missing a full python installation (see T213944#4905485 )

Details

SubjectRepoBranchLines +/-
selenium-daily-beta-* jobs to NodeJS 10integration/configmaster+3 -16
Update selenium-daily defaultsintegration/configmaster+14 -2
docker: sync node10-test-browser with npm-browser-testintegration/configmaster+76 -2
Default selenium-daily-beta-{project} to node10/npm6integration/configmaster+10 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT302086 Set scap minimum python version to 3.7
 ResolvedNoneT247045 Migrate all of production metal and VMs to Buster or later
 ResolvedakosiarisT249724 Track and remove jessie based container images from production
 ResolvedJdforrester-WMFT224908 Drop jessie testing support
 ResolvedJdforrester-WMFT224907 Drop php55 testing support
 ResolvedReedyT205039 Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205041 Tracking bug for 1.27.6/1.30.2/1.31.2/1.32.2 security release
 ResolvedBawolffT197279 Direct POST to Special:ChangeEmail will bypass reauth check
 ResolvedAnomieT204729 Potential enwiki DOS due to slow WatchedItemStore::countVisitingWatchersMultiple
 ResolvedBawolffT207603 CVE-2019-12471: Loading JS from user space where the username is not a registered account is dangerous and should be banned
 ResolvedBawolffT208881 CSS using var() to create exponential sized calc() on wiki page will crash visitor's browser
 ResolvedLegoktmT199540 Forbid blocking IP ranges as big as /1 and /2, as done on ruwikiquote using the API
 ResolvedLucas_Werkmeister_WMDET212118 API responses for unpatrolled or (not) autopatrolled recent changes require privileges but may be cached publicly
 ResolvedBawolffT209794 Need to make a limit of count of attempts to change email address
 ResolvedsbassettT222036 Exposed suppressed username or log in Special:EditTags
 ResolvedsbassettT222038 Exposed suppressed log in RevisionDelete page
 ResolvedJdforrester-WMFT221739 Patch jQuery due to CVE-2019-11358
 ResolvedsbassettT25227 Use token when logging out
 ResolvedsbassettT221868 Send out wikitech-l post for T25227 ("Use token when logging out")
 ResolvedReedyT205042 Write and send release announcements for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedReedyT205043 Write and send pre-release Announcements for MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT205044 Update onwiki release notes for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205046 Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205047 Tag MW 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT224499 RELEASE-NOTES for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT224912 Update MediaWiki.org links and versions
 ResolvedJdforrester-WMFT224913 EOL REL1_27 and REL1_30 onwiki
 ResolvedReedyT225201 Formally announce EOL of MW 1.27 and 1.30
 ResolvedReedyT225149 Update CVEs and publish them
 ResolvedReedyT205048 Obtain CVEs for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedJdforrester-WMFT224906 Drop php56 testing support
 ResolvedhasharT223348 Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x
 ResolvedhasharT210287 Migrate wikimedia-fundraising-civicrm to a Docker container
 ResolvedJdforrester-WMFT224905 Move wikiba.se tests from php56 to php72
 ResolvedhasharT224591 Migrate contint* hosts to Buster
 DeclinedMoritzMuehlenhoffT226236 Upload docker-ce 18.06.3 upstream package for Stretch
 InvalidthciprianiT239880 Replacement hardware for buster/stretch upgrade of contint1001 and contint2001
 ResolvedmmodellT215458 Convert zuul to use scap
 ResolvedhasharT240551 Remove Zuul Debian package from WMCS instances
 ResolvedJoeT249110 Build and publish a python2 based container to build wheels
 ResolvedJMeybohmT249812 Rebuild helm/helm-diff for buster-wikimedia
 ResolvedJMeybohmT250479 Rebuild helmfile for buster-wikimedia
 DuplicateDzahnT210008 upgrade krypton (webserver_misc_apps) to stretch
 DeclinedDzahnT224194 switch webserver_misc_apps to PHP 7.2 (7.1)
 ResolvedJdforrester-WMFT211784 Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects
 ResolvedhasharT217545 Update selenium-daily-beta-* jobs to node10/npm6

Event Timeline

hashar created this task.Mar 4 2019, 10:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2019, 10:49 AM
hashar updated the task description. (Show Details)Mar 4 2019, 10:50 AM
hashar mentioned this in T213944: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7.
gerritbot added a subscriber: gerritbot.Mar 4 2019, 11:20 AM

Change 494199 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Default selenium-daily-beta-{project} to node10/npm6

https://gerrit.wikimedia.org/r/494199

gerritbot added a project: Patch-For-Review.Mar 4 2019, 11:20 AM
gerritbot added a comment.Mar 4 2019, 11:27 AM

Change 494199 merged by jenkins-bot:
[integration/config@master] Default selenium-daily-beta-{project} to node10/npm6

https://gerrit.wikimedia.org/r/494199

zeljkofilipin added a project: User-zeljkofilipin.Mar 4 2019, 12:23 PM
hashar added a comment.Mar 4 2019, 4:43 PM

The container releng/node10-test-browser does not come with the proper entry point (the one who had for releng/npm-test-browser). But adding the entrypoint would cause chromium to be updated to the latest version available in Stretch (v72) which is broken: T216702

So I am first pinning Chromium to v71, rebuild all containers and switch jobs to the new images. Then work on adding the proper entry point and then I will be able to test the upgrade of each of the selenium-daily-beta jobs.

gerritbot added a comment.Mar 4 2019, 9:50 PM

Change 494364 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: sync node10-test-browser with npm-browser-test

https://gerrit.wikimedia.org/r/494364

zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.Mar 5 2019, 10:05 AM
zeljkofilipin removed a project: User-zeljkofilipin.Mar 26 2019, 3:20 PM
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
hashar merged a task: T224978: WikibaseMediaInfo selenium tests failing when run against beta commons.Jun 4 2019, 11:44 AM
hashar added a subscriber: Cparle.

That causes the WikibaseMediaInfo selenium daily job to fail T224978

gerritbot added a comment.Jun 4 2019, 11:50 AM

Change 494364 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: sync node10-test-browser with npm-browser-test

https://gerrit.wikimedia.org/r/494364

gerritbot added a comment.Jun 4 2019, 12:48 PM

Change 494364 merged by jenkins-bot:
[integration/config@master] docker: sync node10-test-browser with npm-browser-test

https://gerrit.wikimedia.org/r/494364

gerritbot added a comment.Jun 4 2019, 1:01 PM

Change 514281 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Update selenium-daily defaults

https://gerrit.wikimedia.org/r/514281

Stashbot added a comment.Jun 4 2019, 1:01 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-04T13:01:51Z] <hashar> Building docker-registry.discovery.wmnet/releng/node10-test-browser:0.6.0 # T217545

gerritbot added a comment.Jun 4 2019, 1:04 PM

Change 514281 merged by jenkins-bot:
[integration/config@master] Update selenium-daily defaults

https://gerrit.wikimedia.org/r/514281

gerritbot added a comment.Jun 4 2019, 1:06 PM

Change 514282 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] selenium-daily-beta-MediaWiki to NodeJS 10

https://gerrit.wikimedia.org/r/514282

gerritbot added a comment.Jun 4 2019, 1:20 PM

Change 514282 merged by jenkins-bot:
[integration/config@master] selenium-daily-beta-* jobs to NodeJS 10

https://gerrit.wikimedia.org/r/514282

hashar added a comment.Jun 4 2019, 1:21 PM

https://integration.wikimedia.org/ci/job/selenium-daily-beta-MediaWiki/292/console does manage to install npm dependencies now.

For other jobs, they will need wdio-mocha-framework 0.6.4 which brings the fibers 3 package that is compatible with NodeJS 10. Example: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/514183/1/package.json

hashar closed this task as Resolved.Jun 4 2019, 1:23 PM
hashar claimed this task.

INFO:jenkins_jobs.builder:Number of jobs generated: 12
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-CirrusSearch
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Echo
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-ElectronPdfService
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Math
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-MediaWiki
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Minerva
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-MobileFrontend
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Newsletter
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Popups
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-RelatedArticles
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-Wikibase
INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-daily-beta-WikibaseLexeme
INFO:jenkins_jobs.cli.subcommand.update:Number of jobs updated: 12

Stashbot added a comment.Jun 4 2019, 1:24 PM

Mentioned in SAL (#wikimedia-releng) [2019-06-04T13:24:02Z] <hashar> Update all selenium-daily* jobs to use NodeJS 10 instead of NodeJS 6. T217545

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL