Page MenuHomePhabricator

Fix JS editability data source
Closed, ResolvedPublic

Description

According to wikibase.ui.entityViewInit.js client side editability depends on

		return mw.config.get( 'wbIsEditView' )
			&& mw.config.get( 'wgRelevantPageIsProbablyEditable' )

Should we not do the same for termbox?
Scenarios: historic revisions, diff pages

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2019, 4:15 PM
Pablo-WMDE updated the task description. (Show Details)Mar 4 2019, 4:29 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-10 board.

Change 494708 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Extend edibility check with 'wbIsEditView'

https://gerrit.wikimedia.org/r/494708

Change 494708 merged by jenkins-bot:
[wikibase/termbox@master] Check editability using wbIsEditView and wgRelevantPageIsProbablyEditable

https://gerrit.wikimedia.org/r/494708

Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:40 AM