Fix JS editability data source
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Mar 4 2019, 4:15 PM

Description

According to wikibase.ui.entityViewInit.js client side editability depends on

		return mw.config.get( 'wbIsEditView' )
			&& mw.config.get( 'wgRelevantPageIsProbablyEditable' )

Should we not do the same for termbox?
Scenarios: historic revisions, diff pages

Details

	Subject	Repo	Branch	Lines +/-
	Check editability using wbIsEditView and wgRelevantPageIsProbablyEditable	wikibase/termbox	master	+6 -3

Customize query in gerrit

Event Timeline

• Pablo-WMDE created this task.Mar 4 2019, 4:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2019, 4:15 PM

• Pablo-WMDE updated the task description. (Show Details)Mar 4 2019, 4:29 PM

Jakob_WMDE claimed this task.Mar 5 2019, 4:17 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-10 board.

Jakob_WMDE reassigned this task from Jakob_WMDE to • Matthias_Geisler_WMDE.Mar 6 2019, 10:45 AM

Change 494708 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Extend edibility check with 'wbIsEditView'

https://gerrit.wikimedia.org/r/494708

gerritbot added a project: Patch-For-Review.Mar 6 2019, 12:56 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-10 board.Mar 6 2019, 1:06 PM

Lea_WMDE added a project: Wikidata-Termbox-Iteration-11.Mar 11 2019, 2:06 PM

Lea_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-11 board.

Change 494708 merged by jenkins-bot:
[wikibase/termbox@master] Check editability using wbIsEditView and wgRelevantPageIsProbablyEditable

https://gerrit.wikimedia.org/r/494708

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-11 board.Mar 11 2019, 4:36 PM

• Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:40 AM

Fix JS editability data sourceClosed, ResolvedPublicActions

Description

Details

Event Timeline

Fix JS editability data source
Closed, ResolvedPublic
Actions