Page MenuHomePhabricator

Scap: server_groups regression
Closed, ResolvedPublic

Description

IMPORTANT: if you're experiencing the same problem for a repo in scap3, remove spaces from your server groups in your scap.cfg; i.e. server_groups: canary, default -> server_groups: canary,default

When attempting to deploy wdqs @Mathew.onipe reported this error from scap:

18:42:03 [deploy1001] Unhandled error:                                                                                                                
Traceback (most recent call last):                                                                                                                    
  File "/usr/lib/python2.7/dist-packages/scap/cli.py", line 342, in run                                                                               
    exit_status = app.main(app.extra_arguments)                                                                                                       
  File "/usr/lib/python2.7/dist-packages/scap/deploy.py", line 639, in main                                                                           
    self._build_deploy_groups()                                                                                                                       
  File "/usr/lib/python2.7/dist-packages/scap/deploy.py", line 981, in _build_deploy_groups                                                           
    self.all_targets = target_obj.all                                                                                                                 
  File "/usr/lib/python2.7/dist-packages/scap/targets.py", line 225, in all                                                                           
    return self.get_deploy_groups()['all_targets']
  File "/usr/lib/python2.7/dist-packages/scap/targets.py", line 197, in get_deploy_groups                                                             
    for group, filename in self._get_filenames_for_groups().items():
  File "/usr/lib/python2.7/dist-packages/scap/targets.py", line 175, in _get_filenames_for_groups                                                     
    'Could not find config setting `{0}`'.format(cfg_key)
RuntimeError: Could not find config setting ` codfw_dsh_targets`
18:42:03 [deploy1001] deploy failed: <RuntimeError> {}

Noteworthy is " codfw_dsh_targets" with a leading space.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 494296 had a related patch set uploaded (by Thcipriani; owner: Thcipriani):
[mediawiki/tools/scap@master] Targets: strip spaces from service_groups

https://gerrit.wikimedia.org/r/494296

Reedy triaged this task as High priority.Mar 4 2019, 9:36 PM
Reedy added a subscriber: Arlolra.
thcipriani updated the task description. (Show Details)Mar 4 2019, 9:43 PM

Change 494365 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid/deploy@master] Remove spaces from server_groups

https://gerrit.wikimedia.org/r/494365

Change 494365 merged by jenkins-bot:
[mediawiki/services/parsoid/deploy@master] Remove spaces from server_groups

https://gerrit.wikimedia.org/r/494365

Change 494296 merged by jenkins-bot:
[mediawiki/tools/scap@master] Targets: strip spaces from service_groups

https://gerrit.wikimedia.org/r/494296

thcipriani closed this task as Resolved.Mar 5 2019, 3:53 PM

Now that 3.9.2-1 is everywhere, this should be resolved.