Page MenuHomePhabricator

Upstream our remaining Civi patches
Closed, ResolvedPublic

Description

I figured we should have a list of issues for upstreaming the patches we are still carrying in our repo-maybe we want a subissue for each one

Applying: wmf: CRM-10700 use DELETE FROM instead of TRUNCATE~~ needs digging as to figure out why this is a performance thing for us~~
Applying: wmf-sunset patch add extra columns to contribution recur tabwe should check this is important before sinking time~
Applying: Hack out version & extension checks.yeah we should get a better way on this
Applying: Do not give validation error on address with no location_type.we have an issue open to fix the data integrity problem requiring this
Applying: When undelete is true, add new contact as assignee for merged contact activity recordWe upstreamed an alternate
Applying: Temporary fix to prevent geocoding on dedupeUpstreamed
Applying: Rude hack to make system checks STFUreally the same issue as hack out version above
Applying: Save our serveropps yeah - same issue again
Applying: Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCountUpstreamed
Applying: Remove another cache bypassUpstreamed
Applying: Remove On Duplicate UPDATE for new inserts to improve performance & reduce deadlocksUpstreamed
Applying: Dedupe debugMoved to module
Applying: HACK: show cancel button for recur records with no processoryeah lets fix
Applying: Less broken version of hacksame as above
d5a39d8 Improve error handlingUpstreamed now - we have a supporting extension
CRM-17156 log user detail in queries to track down long queriesUpstreamed now - we have a supporting extension
Applying: Remove mode & median calculationsalready upstreamed

db7a9600f4 (merged to master upstream) Check field to carry over custom data by default when none is in the other contact's field
e0fde65549 (merged to master upstream) dev/core#1355 Add contention handling for dedupe jobs
30818d2647 (merged to master upstream) Address msExcel export
08520c7db3 Minor caching addition.
f8dc8a0ac3 Revert to hacking out credit note id
fb3b2a5987 Create settings_location.php
bef684f70b Hack out status checks for performance
9b3e96268e Fix 'completed' to be an active status'
dbd0c284bc When undelete is true, add new contact as assignee for merged contact activity record
12c7ab4949 wmf: CRM-10700 use DELETE FROM instead of TRUNCATE

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2019, 8:40 PM

As of 5.22 we have this shorter list

Already merged to master

db7a9600f4 (merged to master upstream) Check field to carry over custom data by default when none is in the other contact's field
e0fde65549 (merged to master upstream) dev/core#1355 Add contention handling for dedupe jobs
30818d2647 (merged to master upstream) Address msExcel export

PR open
08520c7db3 Minor caching addition.

Need to resolve
f8dc8a0ac3 Revert to hacking out credit note id
fb3b2a5987 Create settings_location.php
bef684f70b Hack out status checks for performance
9b3e96268e Fix 'completed' to be an active status'
12c7ab4949 wmf: CRM-10700 use DELETE FROM instead of TRUNCATE

.Nafees791 renamed this task from Upstream our remaining Civi patches to ugvg.Jan 23 2020, 4:38 AM
.Nafees791 updated the task description. (Show Details)
Ammarpad renamed this task from ugvg to Upstream our remaining Civi patches.Jan 23 2020, 5:36 AM
Aklapper updated the task description. (Show Details)Jan 23 2020, 10:16 AM

I've created a bunch of subtasks to break this down - I'm never sure what to do with the parent task as the sub tasks get resolved

woot putting this in review too -but actually only because the last of the subtasks is there

Eileenmcnaughton closed this task as Resolved.Mon, Mar 16, 8:03 PM

This is done since all the parts are done - although