Page MenuHomePhabricator

[subtask] Move sensitive `img` styles to 'images.less'
Open, NormalPublic

Description

Move img styles from 'reset.less' to 'images.less' where useful:

  • General vertical-align and border styling

QA steps

Test articles:

  • Todo

Run the following steps on the above test articles, comparing production content with non-production content post-change

  • Images have to be unchanged in vertical alignment and margin
  • They shouldn't receive a border in a link
  • In general there shouldn't be visual changes before/after this change with images.

Low priority

Do we have QA link where an image can't be loaded within article content, or does this not happen? If it can't be loaded, the visual font treatment (text size) should be same to surrounding text.

Event Timeline

Volker_E created this task.Mar 5 2019, 7:31 AM

Change 494417 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Move sensitive img reset rules to specific LESS files

https://gerrit.wikimedia.org/r/494417

Volker_E updated the task description. (Show Details)Mar 5 2019, 11:28 PM
Jdlrobson updated the task description. (Show Details)Mar 5 2019, 11:41 PM
ovasileva triaged this task as Normal priority.Mar 6 2019, 9:22 AM
Jdlrobson renamed this task from Move sensitive `img` styles to 'images.less' to [subtask] Move sensitive `img` styles to 'images.less'.Mar 8 2019, 12:20 AM

Change 494417 had a related patch set uploaded (by Jdlrobson; owner: VolkerE):
[mediawiki/skins/MinervaNeue@reset-cleanup] Move sensitive img reset rules to specific LESS files

https://gerrit.wikimedia.org/r/494417

Change 494417 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@reset-cleanup] Move sensitive img reset rules to specific LESS files

https://gerrit.wikimedia.org/r/494417