Page MenuHomePhabricator
Create Task
Maniphest T217713

Checkuser throws exception if looking up user with invalid name
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

See XH7ukQpAICsAAK@78zcAAADX (not pasting fully due to sort of sensitive data). Note the Title ends in an underscore, which is illegal for a title.

Bad value for parameter $dbkey: invalid DB key 'REDACTED_'
#0 /srv/mediawiki/php-1.33.0-wmf.19/includes/title/TitleValue.php(105): Wikimedia\Assert\Assert::parameter(boolean, string, string)
#1 /srv/mediawiki/php-1.33.0-wmf.19/includes/cache/LinkBatch.php(179): TitleValue->__construct(integer, string)
#2 /srv/mediawiki/php-1.33.0-wmf.19/includes/cache/LinkBatch.php(143): LinkBatch->addResultToCache(LinkCache, Wikimedia\Rdbms\ResultWrapper)
#3 /srv/mediawiki/php-1.33.0-wmf.19/includes/cache/LinkBatch.php(130): LinkBatch->executeInto(LinkCache)
#4 /srv/mediawiki/php-1.33.0-wmf.19/extensions/CheckUser/includes/CheckUserLogPager.php(116): LinkBatch->execute()
#5 /srv/mediawiki/php-1.33.0-wmf.19/includes/pager/IndexPager.php(231): CheckUserLogPager->preprocessResults(Wikimedia\Rdbms\ResultWrapper)
#6 /srv/mediawiki/php-1.33.0-wmf.19/includes/pager/IndexPager.php(609): IndexPager->doQuery()
#7 /srv/mediawiki/php-1.33.0-wmf.19/includes/pager/ReverseChronologicalPager.php(35): IndexPager->isNavigationBarShown()
#8 /srv/mediawiki/php-1.33.0-wmf.19/extensions/CheckUser/includes/specials/SpecialCheckUserLog.php(70): ReverseChronologicalPager->getNavigationBar()
#9 /srv/mediawiki/php-1.33.0-wmf.19/includes/specialpage/SpecialPage.php(569): SpecialCheckUserLog->execute(NULL)
#10 /srv/mediawiki/php-1.33.0-wmf.19/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.33.0-wmf.19/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.33.0-wmf.19/includes/MediaWiki.php(867): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.33.0-wmf.19/includes/MediaWiki.php(517): MediaWiki->main()
#14 /srv/mediawiki/php-1.33.0-wmf.19/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}

Details

SubjectRepoBranchLines +/-
Validate username input before constructing subpage linksmediawiki/extensions/CheckUsermaster+17 -3
Validate username input before constructing subpage linksmediawiki/extensions/CheckUsermaster+13 -2
Customize query in gerrit

Related Objects

Event Timeline

Bawolff created this task.Mar 5 2019, 10:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2019, 10:06 PM
Bawolff added a project: CheckUser.Mar 5 2019, 10:06 PM
Trijnstel subscribed.Mar 5 2019, 10:13 PM
Aklapper added a project: Wikimedia-production-error.Mar 5 2019, 10:13 PM
Huji claimed this task.Mar 6 2019, 12:35 AM
Huji triaged this task as Medium priority.
Huji subscribed.

I can confirm that ending the username with _ will cause an exception. Looking for the root cause now.

gerritbot subscribed.Mar 6 2019, 3:26 AM

Change 494638 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/extensions/CheckUser@master] Use getSafeTitleFor instead of getTitleFor to make links

https://gerrit.wikimedia.org/r/494638

gerritbot added a project: Patch-For-Review.Mar 6 2019, 3:26 AM
Huji added a comment.Mar 6 2019, 3:27 AM

Guess what, it was a regression that I had introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/374851/ more than year ago!

Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.Mar 9 2019, 12:25 AM
gerritbot added a comment.Mar 19 2019, 11:07 PM

Change 494638 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/extensions/CheckUser@master] Use getSafeTitleFor instead of getTitleFor to make links

https://gerrit.wikimedia.org/r/494638

Jdforrester-WMF moved this task from Nov2019/1.35.wmf.5+ to Older on the Wikimedia-production-error board.Mar 23 2019, 6:16 PM
Jdforrester-WMF subscribed.

374851 landed in 1.31.0-wmf.2.

Meno25 subscribed.May 31 2019, 11:36 AM
Krinkle subscribed.Jun 24 2019, 11:26 PM

Not seen in Logstash for over 30 days. Keeping open because I'm unable to verify it myself given the restricted input. Is this still reproducible?

Huji added a comment.EditedJun 25 2019, 12:49 AM

It is. I just created a log for you on fawiki :)

I haven't been able to find the time to resubmit 494638, which will eventually fix this.

PS: That was the right nudge at the right time, @Krinkle :) I submitted a new patchset.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Krinkle removed a project: Patch-For-Review.Mar 16 2020, 3:00 AM
Aklapper removed a subscriber: CheckUser.Mar 22 2020, 9:23 PM
Huji added a project: Patch-For-Review.Aug 27 2020, 1:01 AM
DannyS712 subscribed.Oct 5 2020, 2:02 AM
gerritbot added a comment.Oct 6 2020, 10:05 PM

Change 494638 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Validate username input before constructing subpage links

https://gerrit.wikimedia.org/r/494638

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 6 2020, 11:00 PM
Huji closed this task as Resolved.Oct 7 2020, 12:16 AM
Urbanecm reopened this task as Open.Oct 15 2020, 3:14 PM
Urbanecm subscribed.

Patch was reverted, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/634246.

gerritbot added a comment.Oct 15 2020, 3:17 PM

Change 634269 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CheckUser@master] Validate username input before constructing subpage links

https://gerrit.wikimedia.org/r/634269

Urbanecm mentioned this in T265606: CheckUserLog invisible on meta, mediawiki.org, wikidata, but visible on kowiki.Oct 15 2020, 3:55 PM
Huji closed this task as Resolved.Oct 16 2020, 6:06 PM

The new patch does the job correctly.

Unfortunately, I cannot think of any way to create a unit test for this. Closing now because I just +2 the new patch.

gerritbot added a comment.Oct 16 2020, 6:29 PM

Change 634269 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Validate username input before constructing subpage links

https://gerrit.wikimedia.org/r/634269

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.14; 2020-10-20); removed MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 16 2020, 7:00 PM
Meno25 unsubscribed.Oct 18 2020, 10:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL