MinveraNeue: Evaluate using MW core shared.css in styles coverage and performance
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Mar 5 2019, 11:58 PM

Description

Problem

Coming from T217616, a lot of the long-term internationalization logic and some general core styles (like wikitable, success and errorboxes, etc.) have been collected in shared.css

MinervaNeue doesn't make use of it currently providing a less than acceptable experience in non-latin scripts on example given in T217616.

Evaluate

Proposed usage of shared.css in MinveraNeue in

scope
performance (size added after gzip minus the possible deletion of duplicated styles in MinervaNeue as of to date)

'shared.css' as of 2019-03-05: P8164
Minified and gzipped it's 2.4kB (2,466 bytes).

Related Objects

Mentioned Here: P8164 MW core shared.css 2019-03-05
T217616: Ordered lists per default receive `decimal` list style type, which causes issues in non-arabic numeral scripts

Event Timeline

Volker_E created this task.Mar 5 2019, 11:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2019, 11:58 PM

Volker_E updated the task description. (Show Details)Mar 6 2019, 12:07 AM

Volker_E updated the task description. (Show Details)Mar 6 2019, 12:16 AM

Jdlrobson added a project: Web-Team-Backlog-Archived.Mar 6 2019, 12:51 AM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.

ovasileva triaged this task as Medium priority.Mar 6 2019, 9:22 AM

Not a top priority from my perspective right now. Ideally I'd like to think about this come May/June. Happy to raise this priority if it's blocking any particular work but it will be at expense of other things.

@Jdlrobson So how do we address non-Arabic numeral issue then in T217616?

The module is 2.9kb of CSS after gzipping. Given the mobile site currently is 7.33kb of critical CSS, this is a large amount of CSS to add. We need to work out which bits of this are actually critical.

We talked about this in frontend standards group today and proposed we replace mediawiki.interface with an importable LESS file that skins can choose to import. All existing skins using the module would import the new module.
We can work out how granular this needs to be for Minerva.

e.g.

@import "mediawiki.interface";

We are breaking ResourceLoaderSkinModule into chunks that a skin can choose to pick up. A solution for T217616 now exists.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 17 2020, 11:24 PM

MinveraNeue: Evaluate using MW core shared.css in styles coverage and performanceClosed, ResolvedPublicActions