Page MenuHomePhabricator
Create Task
Maniphest T217726

Special:PageMigration - Page search suggestion does not work
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
abi_
Authored By
abi_
Mar 6 2019, 7:39 AM
Tags
Referenced Files
F34763349: image.png
Nov 23 2021, 2:29 PM
F34763347: image.png
Nov 23 2021, 2:29 PM
F29220568: image.png
May 23 2019, 10:19 AM
Subscribers
abi_
Aklapper
gerritbot
Nikerabbit

Description

Steps to reproduce

  1. Open Special:PageMigration
  2. Search in the Textbox for the name of a page

Expected behavior

Pages starting with a similar name should be shown in the suggestion box.

Actual behavior
No suggestion box appears, and an error is logged in the console.

Additional info
Here's the error logged in the console,

Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at getFormData (searchSuggest.js?ed05e:54)

This is happening because our HTML Form does not have an action attribute and getFormData expects an action attribute. See code from that function below,

baseHref = $form.attr( 'action' );
baseHref += baseHref.indexOf( '?' ) > -1 ? '&' : '?';

This seems to be only used for tracking purposes.

Couple of things could be done to fix this,

  1. Add an empty action attribute to the form in SpecialPageMigration.php
  2. Add a check in getFormData before doing indexOf ... which I think we should do either way.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+28 -14PageMigration: Refactor code to make error handling simpler
mediawiki/extensions/Translatemaster+16 -0PageMigration: Handle invalid group when fetching translation units
mediawiki/extensions/Translatemaster+4 -2Fix page suggestion not working on Special:PageMigration
Customize query in gerrit

Related Objects

Event Timeline

abi_ triaged this task as Medium priority.Mar 6 2019, 7:39 AM
abi_ created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2019, 7:39 AM
abi_ mentioned this in T178642: Link to Special:PageMigration in the MediaWiki:Tpt-saveok (or in the new msg).Mar 6 2019, 12:52 PM
abi_ moved this task from Backlog to In Progress on the User-abi_ board.Mar 13 2019, 8:59 AM
gerritbot added a subscriber: gerritbot.Mar 13 2019, 6:38 PM

Change 496233 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix page suggestion not working on Special:PageMigration

https://gerrit.wikimedia.org/r/496233

gerritbot added a project: Patch-For-Review.Mar 13 2019, 6:38 PM
abi_ moved this task from In Progress to Under Review on the User-abi_ board.Mar 13 2019, 6:47 PM

There were two issues here,

  1. When typing the name of the page, the suggestion dropdown was not visible. This was because the searchSuggest plugin expects the parent form to have an action attribute and this was missing for the form on the Migration page.
  2. Once the above issue was fixed, noticed that clicking on the suggestions would redirect the user.

Fixed the first issue by adding an empty action attribute to the form. The second was fixed by adding data-mw-searchsuggest="{ "wrapAsLink": false }" to the suggestion box input.

Note that there is an existing issue T217727: Special:PageMigration - "query - messagecollection" API throws an error due to which clicking on the import button will not do anything.

Test Case

Please find the test case below,

TC #1 - Suggestion box should display the list of pages with similar name

  1. Open the Special:PageMigration
  2. Start typing the name of the page that you know exists in the Wiki.
  3. Click on any one of the pages that appears in the suggestion list.

Expected Behavior

After step 2, you should see the suggestion box appear. On performing step 3, no redirection should occur and the clicked page name should simply get populated in the textbox.

gerritbot added a comment.Mar 18 2019, 11:56 AM

Change 496233 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix page suggestion not working on Special:PageMigration

https://gerrit.wikimedia.org/r/496233

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 18 2019, 12:01 PM
abi_ moved this task from Under Review to QA on the User-abi_ board.Mar 18 2019, 2:24 PM

Moving to QA

abi_ removed a project: Patch-For-Review.Mar 18 2019, 2:25 PM
abi_ added a comment.Mar 18 2019, 2:28 PM

Niklas noticed an issue with the searchSuggestion plugin when using the Timeless skin. I've reported it here - T218565: Search suggestion appears in the same location for all searchSuggestion instances

Nikerabbit moved this task from Backlog to page migration on the MediaWiki-extensions-Translate board.Mar 18 2019, 3:15 PM
Nikerabbit moved this task from QA to Done on the User-abi_ board.May 7 2019, 9:08 AM

I have confirmed this on dev.translatewiki.net. With latest changes to Timeless, the dropdown is also correctly positioned.

There is some possible issue that nothing seems to happen on invalid input when submitting the form.

abi_ added a comment.May 12 2019, 4:04 PM

There is some possible issue that nothing seems to happen on invalid input when submitting the form.

@Nikerabbit - What sort of invalid input? I'm seeing an error message pop up above the page title textbox based on what sort of invalid input I enter.

Nikerabbit added a comment.May 13 2019, 6:02 AM

Specifically the case of a page with a language code which is not a translatable page seems to not cause any message at all. (For example MediaWiki:Jan/fi assuming that the page exists).

abi_ added a comment.May 23 2019, 10:19 AM

I'm seeing the following -

image.png (355×735 px, 13 KB)

Here T217726_1/fi is a page that exists, but is not translatable.

Nikerabbit added a comment.EditedMay 23 2019, 2:02 PM

Can you reproduce the issue at https://translatewiki.net/wiki/Special:PageMigration with MediaWiki:Jan/fi as input?

abi_ added a comment.Jun 30 2019, 8:55 AM
In T217726#5208112, @Nikerabbit wrote:

Can you reproduce the issue at https://translatewiki.net/wiki/Special:PageMigration with MediaWiki:Jan/fi as input?

Hi @Nikerabbit - Sorry for the delayed response. I do not have permissions to the migration page. Requires Bureaucrat permissions.

Nikerabbit added a comment.Jul 1 2019, 6:49 AM

Bureaucrat is a user group. The right is is pagetranslation.

Jdlrobson mentioned this in T266507: TypeError: baseHref is undefined on wikidata.org search.Oct 26 2020, 8:38 PM
Pginer-WMF added a project: Language-Team (Language-2021-October-December).Oct 4 2021, 11:49 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2021-October-December) board.Oct 4 2021, 11:51 AM
Pginer-WMF moved this task from Priority: Localization infrastructure to Quarter Backlog on the Language-Team (Language-2021-October-December) board.Oct 5 2021, 6:53 AM
abi_ moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2021-October-December) board.Nov 1 2021, 1:34 PM
gerritbot added a comment.Nov 1 2021, 5:20 PM

Change 736013 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] PageMigration: Handle invalid group when fetching translation units

https://gerrit.wikimedia.org/r/736013

gerritbot added a project: Patch-For-Review.Nov 1 2021, 5:20 PM
gerritbot added a comment.Nov 9 2021, 11:34 AM

Change 736013 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageMigration: Handle invalid group when fetching translation units

https://gerrit.wikimedia.org/r/736013

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 9 2021, 12:00 PM
abi_ claimed this task.Nov 9 2021, 4:34 PM
abi_ moved this task from Priority: Localization infrastructure to Recheck after deployment on the Language-Team (Language-2021-October-December) board.
Nikerabbit moved this task from Recheck after deployment to Priority: Localization infrastructure on the Language-Team (Language-2021-October-December) board.Nov 15 2021, 1:59 PM
Nikerabbit removed a project: Patch-For-Review.

Did not pass QA. Still an issue with message groups that are not translatable pages.

gerritbot added a comment.Nov 19 2021, 4:22 PM

Change 740195 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] PageMigration: Handle message groups that are non translatable pages

https://gerrit.wikimedia.org/r/740195

gerritbot added a project: Patch-For-Review.Nov 19 2021, 4:22 PM
abi_ changed the task status from Open to In Progress.Nov 23 2021, 4:04 AM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Nov 23 2021, 12:05 PM

Change 740195 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageMigration: Refactor code to make error handling simpler

https://gerrit.wikimedia.org/r/740195

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 23 2021, 1:00 PM
abi_ closed this task as Resolved.Nov 23 2021, 2:29 PM
abi_ moved this task from In Review to Done on the Language-Team (Language-2021-October-December) board.

This is fixed. Tested on Translatewiki.net

Eg 1:

image.png (253×588 px, 15 KB)

Eg 2:

image.png (243×637 px, 15 KB)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL