Page MenuHomePhabricator

Remove SchemaText from SetLabelDescAliases special page
Closed, ResolvedPublic

Description

Currently, Special:SetSchemaLabelDescriptionAliases uses the` MonolingualSchemaData` value-object to get the data, including the Schema text and it writes the Data with MediaWikiRevisionSchemaWriter::updateSchema method, also including the Schema text. However, since the Schema text is not supposed to be edited, this is unnecessary and should be removed.

Acceptance criteria

  • The data from the special page is saved using MediaWikiRevisionSchemaWriter::updateSchemaNameBadge
  • The special page does not include a field for the Schema text (hidden or otherwise)
  • The data is retrieved from the SchemaDispatcher in a way that does not include the Schema text

Event Timeline

This means adding a 'getNameBadgeById()' to the SchemaDispatcher and using it in Special:SetSchemaLabelDescriptionAliases instead of getMonolingualSchemaData()

Change 494688 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseSchema@master] Add method getMonolingualNameBadgeData to SchemaDispatcher and use it

https://gerrit.wikimedia.org/r/494688

Change 494688 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add method getMonolingualNameBadgeData to SchemaDispatcher and use it

https://gerrit.wikimedia.org/r/494688