Catch Exceptions where the entity can not be serialized due to being too big and Log & present the user with a nice error in APIs
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Our handling of the issue of entities being "too large" leaves something to be desired.

In T215380 when people try to edit large items we just end up spamming the logs with exceptions.
Instead we should spam the logs with something a little less scary Notice or Warning and show a nice error to the user instead of an exception.

Should be fixed for:

Wikibase APIs
WikibaseLexeme APIs
Special Pages

Details

Subject	Repo	Branch	Lines +/-
Catch Exceptions where the entity can not be serialized due to being too big	mediawiki/extensions/Wikibase	master	+55 -17
Catch Exceptions where the entity can not be serialized due to being too big	mediawiki/extensions/Wikibase	master	+29 -22
Catch Exceptions where the entity can not be serialized due to being too big	mediawiki/extensions/Wikibase	master	+29 -22

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	PRODUCTION ERROR	noarave	T215380 Content too big! Entity: Q27972199
		Resolved		noarave	T217741 Catch Exceptions where the entity can not be serialized due to being too big and Log & present the user with a nice error in APIs

Event Timeline

Addshore created this task.Mar 6 2019, 9:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2019, 9:59 AM

Addshore removed Magnus as the assignee of this task.Mar 6 2019, 10:00 AM

Addshore triaged this task as Medium priority.

Addshore moved this task from Incoming to Needs Work on the Wikidata-Campsite board.

Addshore added a subscriber: Magnus.

Addshore moved this task from Needs Work to Ready to estimate on the Wikidata-Campsite board.Mar 12 2019, 2:03 PM

• alaa_wmde set the point value for this task to 3.Mar 12 2019, 3:56 PM

Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Mar 12 2019, 3:56 PM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from Wikidata-Campsite-Iteration-∞ (On Hold) to Ready to estimate on the Wikidata-Campsite board.Mar 12 2019, 4:03 PM

Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

• alaa_wmde updated the task description. (Show Details)Mar 12 2019, 4:28 PM

noarave claimed this task.Apr 10 2019, 7:43 AM

noarave edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Restricted Application added a project: User-Noarave. · View Herald TranscriptApr 10 2019, 7:43 AM

noarave moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 10 2019, 7:44 AM

Change 504264 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] WIP Catch Exceptions where the entity can not be serialized due to being too big

https://gerrit.wikimedia.org/r/504264

gerritbot added a project: Patch-For-Review.Apr 16 2019, 8:17 AM

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 17 2019, 7:23 AM

noarave moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 18 2019, 9:07 AM

Change 506353 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Catch Exceptions where the entity can not be serialized due to being too big

https://gerrit.wikimedia.org/r/506353

Change 506354 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/Wikibase@master] Catch Exceptions where the entity can not be serialized due to being too big

https://gerrit.wikimedia.org/r/506354

Change 506354 abandoned by Noa wmde:
Catch Exceptions where the entity can not be serialized due to being too big

Reason:
duplicate change

https://gerrit.wikimedia.org/r/506354

Change 506353 abandoned by Noa wmde:
Catch Exceptions where the entity can not be serialized due to being too big

Reason:
duplicate change

https://gerrit.wikimedia.org/r/506353

noarave moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 25 2019, 10:00 AM

Change 504264 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Catch Exceptions where the entity can not be serialized due to being too big

https://gerrit.wikimedia.org/r/504264

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 2 2019, 11:42 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 2 2019, 12:00 PM

WMDE-leszek mentioned this in T215380: Content too big! Entity: Q27972199.May 9 2019, 12:26 PM

Claiming this done as long as not proven otherwise in T215380.