Page MenuHomePhabricator

Database::selectSQLText should prefix 'table_name.*'
Open, Needs TriagePublic

Description

Using Database::select or any similar function which calls selectSQLText with 'table_name.*' in the $vars argument will fail if a table prefix is set. This, for instance, makes such code untestable with PHPUnit (T217487). While selecting '*' is seldom the right thing to do, we should nevertheless keep it working.

Event Timeline

Daimona created this task.Mar 6 2019, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2019, 10:27 AM

Change 494040 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] [WIP] Add table prefix when using 'table_name.*' in SELECT

https://gerrit.wikimedia.org/r/494040

Daimona claimed this task.Mar 6 2019, 10:29 AM
Krinkle moved this task from Backlog to libs/rdbms on the MediaWiki-Database board.Apr 3 2019, 2:48 AM