Page MenuHomePhabricator

Deprecate and remove mw.config wgAvailableSkins
Closed, ResolvedPublic

Description

I added this in 2011 for use in the QUnit test runner for MediaWiki. (r80790, r80792)

In 2011, we did not yet have Special:JavaScriptTest. Our tests still ran statically from an HTML file, which meant the only (easy) way to export values was through the startup module. Nowadays, if we needed this, we'd export it within the file module module, or by using addJsConfigVars() on the spcial page where we need it only – not globally.

While the special page had various benefits, the fact that it was skinned was not a benefit. In 2015, for that reason, we created a "plain" mode instead, and also removed the skin-chooser with 6b758fc982972e, and 0f9e4ca0fb7ce.

But... I forgot to remove this variable. It's still exported globally.

Event Timeline

Krinkle created this task.Mar 6 2019, 2:38 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 6 2019, 2:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 494744 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Remove wgAvailableSkins from mw.config

https://gerrit.wikimedia.org/r/494744

Krinkle claimed this task.Mar 6 2019, 3:17 PM
Krinkle triaged this task as Low priority.

Change 494744 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Remove wgAvailableSkins from mw.config

https://gerrit.wikimedia.org/r/494744

Krinkle closed this task as Resolved.Mar 6 2019, 11:20 PM
Krinkle removed a project: Patch-For-Review.