Page MenuHomePhabricator

inlabel / incaption keywords should highlight the label/caption
Closed, ResolvedPublic

Description

For example on this search:

https://wikidata.beta.wmflabs.org/w/index.php?search=&search=inlabel%3Atest%40en&title=Special%3ASearch&go=Go

The word test should be highlighted, but is not. Additionally some results show no snippet at all. They should at a minimum provided a snippet from the matched label.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2019, 12:34 AM

Change 495279 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

Change 495281 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

Change 495279 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

Change 500865 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Pass primary query to SearchContext::getHighlight

https://gerrit.wikimedia.org/r/500865

Change 500867 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Deprecate usage of SearchContext::getHighlight without $mainQuery

https://gerrit.wikimedia.org/r/500867

Change 500865 abandoned by EBernhardson:
Pass primary query to SearchContext::getHighlight

Reason:
squash into Ic1ae01d10076993a79dd0168e84089560ea4ec54

https://gerrit.wikimedia.org/r/500865

Change 495281 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

Change 495279 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

Change 495281 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

All results to demo query now show one highlighted thing, so that is progress. Some items still don't show a snippet, but clicking through to the result page I'm not sure what could have been displayed in the snippet anyways. The initial goal seems to be complete.

debt closed this task as Resolved.Apr 5 2019, 10:28 PM

Change 500867 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Deprecate usage of SearchContext::getHighlight without $mainQuery

https://gerrit.wikimedia.org/r/500867