Page MenuHomePhabricator
Create Task
Maniphest T217809

inlabel / incaption keywords should highlight the label/caption
Closed, ResolvedPublic
Actions

Description

For example on this search:

https://wikidata.beta.wmflabs.org/w/index.php?search=&search=inlabel%3Atest%40en&title=Special%3ASearch&go=Go

The word test should be highlighted, but is not. Additionally some results show no snippet at all. They should at a minimum provided a snippet from the matched label.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deprecate usage of SearchContext::getHighlight without $mainQuerymediawiki/extensions/CirrusSearchmaster+3 -0
Pass primary query to SearchContext::getHighlightmediawiki/extensions/WikibaseCirrusSearchmaster+1 -1
Highlight inlabel: resultsmediawiki/extensions/WikibaseCirrusSearchmaster+8 -2
Include main query in highlight query when using nonText highlight queriesmediawiki/extensions/CirrusSearchmaster+166 -7
Customize query in gerrit

Related Objects

Event Timeline

EBernhardson created this task.Mar 7 2019, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2019, 12:34 AM
gerritbot subscribed.Mar 8 2019, 6:59 PM

Change 495279 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

gerritbot added a project: Patch-For-Review.Mar 8 2019, 6:59 PM
gerritbot added a comment.Mar 8 2019, 7:10 PM

Change 495281 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

EBernhardson mentioned this in rEWCSeafee0f3fdc7: Highlight inlabel: results.Mar 8 2019, 7:11 PM
gerritbot added a comment.Apr 2 2019, 11:19 PM

Change 495279 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

gerritbot added a comment.Apr 2 2019, 11:44 PM

Change 500865 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Pass primary query to SearchContext::getHighlight

https://gerrit.wikimedia.org/r/500865

EBernhardson mentioned this in rEWCS1036b129c6b1: Pass primary query to SearchContext::getHighlight.Apr 2 2019, 11:45 PM
gerritbot added a comment.Apr 2 2019, 11:51 PM

Change 500867 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Deprecate usage of SearchContext::getHighlight without $mainQuery

https://gerrit.wikimedia.org/r/500867

EBernhardson mentioned this in rEWCSbecace5cf91c: Pass primary query to SearchContext::getHighlight.Apr 2 2019, 11:54 PM
gerritbot added a comment.Apr 3 2019, 12:03 AM

Change 500865 abandoned by EBernhardson:
Pass primary query to SearchContext::getHighlight

Reason:
squash into Ic1ae01d10076993a79dd0168e84089560ea4ec54

https://gerrit.wikimedia.org/r/500865

gerritbot added a comment.Apr 3 2019, 12:04 AM

Change 495281 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

EBernhardson mentioned this in rEWCS608b8d8b7e02: Highlight inlabel: results.Apr 3 2019, 12:07 AM
gerritbot added a comment.Apr 3 2019, 9:23 AM

Change 495279 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Include main query in highlight query when using nonText highlight queries

https://gerrit.wikimedia.org/r/495279

gerritbot added a comment.Apr 3 2019, 9:42 AM

Change 495281 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Highlight inlabel: results

https://gerrit.wikimedia.org/r/495281

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 10:01 AM
dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Apr 3 2019, 10:24 AM
EBernhardson added a comment.Apr 3 2019, 9:20 PM

All results to demo query now show one highlighted thing, so that is progress. Some items still don't show a snippet, but clicking through to the result page I'm not sure what could have been displayed in the snippet anyways. The initial goal seems to be complete.

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Apr 3 2019, 9:21 PM
• debt closed this task as Resolved.Apr 5 2019, 10:28 PM
gerritbot added a comment.Apr 18 2019, 4:19 PM

Change 500867 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Deprecate usage of SearchContext::getHighlight without $mainQuery

https://gerrit.wikimedia.org/r/500867

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 18 2019, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits