Page MenuHomePhabricator

Add scenario options to Fresnel comparison output
Open, LowPublic

Description

Following on T216854: Configure scenarios by key instead of index (more descriptive build output).

The labels are an improvement, but adding the options themselves (url, viewport) would be better.

Currently

Screenshot 2019-03-07 at 18.24.38.png (1×1 px, 439 KB)

Screenshot 2019-03-07 at 18.21.05.png (784×1 px, 143 KB)

Event Timeline

Krinkle changed the task status from Open to Stalled.Apr 8 2019, 8:18 PM

Let's do T220433 first so that we don't end up with another level of section separation and/or more repeated output.

Krinkle changed the task status from Stalled to Open.May 20 2019, 11:07 PM
Krinkle added a project: patch-welcome.

Hoping to take a look at this within RelEng as new owners for our next sprint!

Hi @Krinkle. Can you provide a fleshed out example of what you want the new output to look like?

Scenario's are configured like this in .fresnel.yml:

runs: 7
scenarios:
  View history of a page:
    url: "{MW_SERVER}{MW_SCRIPT_PATH}/index.php?action=history"
    viewport:
      width: 1100
      height: 700
    reports:
      - navtiming
      - paint
      - transfer
    probes:
      - screenshot
      - trace

I suppose the idea would be to print this information during the record step. Right now, recording prints 1 line for each run, stating the scenario label and the run number, followed by what the recording does (usually, 1 navigation, and then collecting metrics).

You could e.g. print the scenario options in full, right before the first run or something like that.

Change 1003455 had a related patch set uploaded (by Thcipriani; author: Thcipriani):

[performance/fresnel@master] Print more scenario information during record and compare

https://gerrit.wikimedia.org/r/1003455