Page MenuHomePhabricator

test_RC_pagegenerator_result fails with KeyError
Closed, ResolvedPublic

Description

======================================================================
 4932FAIL: test_RC_pagegenerator_result (tests.pagegenerators_tests.EventStreamsPageGeneratorTestCase)
 4933Test RC pagegenerator.
 4934----------------------------------------------------------------------
 4935Traceback (most recent call last):
 4936  File "c:\projects\pywikibot-g4xqx\tests\pagegenerators_tests.py", line 1587, in test_RC_pagegenerator_result
 4937    self.assertIn(key, rcinfo.keys())
 4938AssertionError: u'id' not found in [u'comment', u'wiki', u'server_name', u'server_script_path', u'log_id', u'namespace', u'parsedcomment', u'bot', u'log_params', u'server_url', u'meta', u'log_action', u'timestamp', u'title', u'log_action_comment', u'type', u'log_type', u'user']

As I can see “id” is not mandatory in the eventstreams result for recenchanges as I expected.

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/22780601/job/qwfl624wuu9mxsw4

Details

Event Timeline

Xqt triaged this task as High priority.Mar 8 2019, 6:05 AM
Xqt updated the task description. (Show Details)

Change 495172 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Remove test for 'id' in rcinfo.keys()

https://gerrit.wikimedia.org/r/495172

Xqt added a subscriber: Ottomata.

@Ottomata: can you confirm my assumption?

Change 495172 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Remove test for 'id' in rcinfo.keys()

https://gerrit.wikimedia.org/r/495172

Xqt closed this task as Resolved.