Add functional test coverage for link inspector and others
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 9 2019, 4:35 PM

Description

Files in ui/inspectors contains some pretty critical functionality about how users interact with links, but our coverage is woeful:

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (8f10e06af)	mediawiki/extensions/VisualEditor	master	+1 -1
	Add more inspector tests	VisualEditor/VisualEditor	master	+45 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• marcella	T206138 [EPIC] Increase test coverage for VE.ce code
		Resolved		Esanders	T217957 Add functional test coverage for link inspector and others

Event Timeline

Esanders created this task.Mar 9 2019, 4:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2019, 4:35 PM

Patch: https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/495276/

Coverage after patch:

Esanders moved this task from Incoming to Engineering QA on the VisualEditor (Current work) board.Mar 9 2019, 4:37 PM

Change 495462 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Add more inspector tests

https://gerrit.wikimedia.org/r/495462

gerritbot added a project: Patch-For-Review.Mar 9 2019, 5:30 PM

After 2nd patch:

Change 495462 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Add more inspector tests

https://gerrit.wikimedia.org/r/495462

Change 495458 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8f10e06af)

https://gerrit.wikimedia.org/r/495458

Change 495458 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8f10e06af)

https://gerrit.wikimedia.org/r/495458

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.21; 2019-03-12); removed Patch-For-Review.Mar 12 2019, 3:23 PM

Esanders moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Mar 13 2019, 5:51 PM

• ppelberg closed this task as Resolved.Mar 13 2019, 9:59 PM

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 17 2019, 12:03 AM