Page MenuHomePhabricator

Some edits aren't recorded as having been saved in AbuseLog (no diff link)
Open, Needs TriagePublic

Description

See this log for filter 61 with the Impact set to "without saved changes": https://en.wikipedia.org/wiki/Special:AbuseLog?wpSearchUser=&wpSearchPeriodStart=&wpSearchPeriodEnd=2019-03-10T02%3A37%3A05.000Z&wpSearchTitle=&wpSearchImpact=2&wpSearchAction=any&wpSearchActionTaken=&wpSearchFilter=61

The first one by 166.48.60.66 was actually saved. Their abuse log shows filter 61 as the only one that was tripped when they made their edit.

In fact, I was testing the filter using Special:AbuseFilter/test against recent changes, and I saw the above edit show up and it had a diff link. So apparently it just wasn't recorded as a "saved change" in AbuseFilter.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2019, 2:46 AM

This bug (I think it's a bug) seems to be somewhat widespread. Checking the abuse log for any filter, I see a lot of edits that appear to be not saved but they were.

Daimona added a subscriber: Daimona.

Confirming. I also noticed the same thing on itwiki a few days ago, but forgot to investigate further. Of note, it's not easy to detect such edits: one may filter the AbuseLog with impact:not saved AND actions taken:none (or tag), but page creations would show up all the same (see e.g. T62179). I don't know why this happens, but I have to say that the code used to populate afl_rev_id (which signals that the edit succeeded) is pretty brittle (see onPageContentSaveComplete). I sort of tried to clean the code a bit in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/478489/, but that's far from being perfect.

Daimona moved this task from Backlog to Future on the User-Daimona board.Mar 22 2019, 7:02 PM