Listing tickets "Closed By: Current Viewer" while logged out causes PhabricatorTypeaheadInvalidTokenException: This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)".
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	TheDragonFire
	Mar 10 2019, 3:56 AM

Project Tags

Referenced Files

None

Subscribers

Description

Upstreamed as https://we.phorge.it/T15704

While logged out, listing resolved tickets errors:

Unhandled Exception ("PhabricatorTypeaheadInvalidTokenException")
This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)".

 [2023-08-14 13:58:57] EXCEPTION: (PhabricatorTypeaheadInvalidTokenException) This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)". at [<phabricator>/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php:497]
 arcanist(), ava(), phabricator(), translations(), wmf-ext-misc()
   #0 <#2> PhabricatorTypeaheadDatasource::parseFunction(string) called at [<phabricator>/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php:280]
   #1 <#2> PhabricatorTypeaheadDatasource::renderTokens(array) called at [<phabricator>/src/view/form/control/AphrontFormTokenizerControl.php:76]
   #2 <#2> AphrontFormTokenizerControl::renderInput() called at [<phabricator>/src/view/form/control/AphrontFormControl.php:172]
   #3 <#2> phutil_tag(string, array, array) called at [<phabricator>/src/view/form/PHUIFormLayoutView.php:54]
   #4 <#2> PHUIFormLayoutView::render() called at [<phabricator>/src/view/form/AphrontFormView.php:160]
   #5 <#2> phutil_escape_html(AphrontFormView) called at [<phabricator>/src/infrastructure/markup/render.php:97]
   #6 <#2> phutil_tag(string, array, AphrontFormView) called at [<phabricator>/src/view/phui/PHUIObjectBoxView.php:245]
   #7 <#2> PHUIObjectBoxView::getTagContent() called at [<phabricator>/src/view/AphrontTagView.php:161]
   #8 <#2> AphrontTagView::render() called at [<phabricator>/src/view/AphrontView.php:222]
   #9 <#2> AphrontView::producePhutilSafeHTML() called at [<phabricator>/src/infrastructure/markup/render.php:115]
   #10 <#2> phutil_escape_html(PHUIObjectBoxView) called at [<phabricator>/src/infrastructure/markup/render.php:139]
   #11 <#2> phutil_escape_html(array) called at [<phabricator>/src/infrastructure/markup/render.php:171]
   #12 <#2> phutil_implode_html(string, array) called at [<phabricator>/src/view/page/PhabricatorBarePageView.php:58]
   #13 <#2> PhabricatorBarePageView::willRenderPage() called at [<phabricator>/src/view/page/PhabricatorStandardPageView.php:217]
   #14 <#2> PhabricatorStandardPageView::willRenderPage() called at [<phabricator>/src/view/page/AphrontPageView.php:46]
   #15 <#2> AphrontPageView::render() called at [<phabricator>/src/view/page/PhabricatorStandardPageView.php:911]
   #16 <#2> PhabricatorStandardPageView::produceAphrontResponse() called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:722]
   #17 <#2> AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:299]
   #18 phlog(PhabricatorTypeaheadInvalidTokenException) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
   #19 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, PhabricatorTypeaheadInvalidTokenException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
   #20 AphrontApplicationConfiguration::handleThrowable(PhabricatorTypeaheadInvalidTokenException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:337]
   #21 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]
   #22 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]

cf. old upstream https://secure.phabricator.com/T11606

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		valerio.bozzolan	T356384 Phorge (Phabricator) Code Sprint 2024
Resolved	BUG REPORT	valerio.bozzolan	T217984 Listing tickets "Closed By: Current Viewer" while logged out causes PhabricatorTypeaheadInvalidTokenException: This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)".
Resolved		brennen	T370266 Update to Phorge upstream 2024.35 release
Resolved		Marostegui	T390034 Prepare a database test for m3
Resolved		ABran-WMF	T397886 PuppetDisabled - phab1005:9100
Resolved		Pppery	T399604 Update Phabricator translations to 2024.35 release

Event Timeline

TheDragonFire created this task.Mar 10 2019, 3:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2019, 3:56 AM

Aklapper renamed this task from Listing resolved tickets causes PhabricatorTypeaheadInvalidTokenException while logged out to Listing resolved tickets while logged out causes PhabricatorTypeaheadInvalidTokenException: This datasource ("PhabricatorPeopleUserFunctionDatasource") can not evaluate the function "viewer(...)"..Mar 10 2019, 9:47 AM

Confirming; thanks for reporting this.

Note that the query has "Closed By: Current Viewer" set. Same behavior in upstream.

Restricted Application added a project: Upstream. · View Herald TranscriptMar 10 2019, 9:50 AM

Aklapper triaged this task as Lowest priority.Mar 10 2019, 11:11 AM

Aklapper raised the priority of this task from Lowest to Low.Oct 27 2023, 10:04 AM

Aklapper updated the task description. (Show Details)

Aklapper changed the subtype of this task from "Task" to "Bug Report".

Go to http://phorge.localhost/maniphest/query/advanced/
Set "Closed By" to "Current Viewer" and Search.
Open the resulting query URL in an incognito window without being logged into Phorge.

A quick hack to provide a better error message is below, however that ignores the abstraction model not to special-case child classes in the parent's parent class.

diff --git a/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php b/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
index a35a8e8f0f..3a99443fac 100644
--- a/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
+++ b/src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
@@ -498,6 +498,10 @@ abstract class PhabricatorTypeaheadDatasource extends Phobject {
 
     if (!$this->canEvaluateFunction($function)) {
       if (!$allow_partial) {
+        if (get_class($this) === "PhabricatorPeopleUserFunctionDatasource" && !$this->getViewer()->isLoggedIn()) {
+          throw new PhabricatorTypeaheadInvalidTokenException(
+            pht('You must log in to use a query which sets the current viewer as a query parameter.'));
+        }
         throw new PhabricatorTypeaheadInvalidTokenException(
           pht(
             'This datasource ("%s") can not evaluate the function "%s(...)".',

Aklapper claimed this task.Jan 4 2024, 11:33 AM

Aklapper moved this task from Backlog to Upstreamed on the Phabricator (Upstream) board.

Aklapper updated the task description. (Show Details)

Aklapper moved this task from Backlog to Patch proposed upstream on the Upstream board.Jan 4 2024, 11:42 AM

valerio.bozzolan subscribed.May 7 2024, 4:40 PM

I've seen the old upstream Task but I think it's not relevant to this issue.

Thanks for this beautiful troubleshooting. Maybe we can be able to directly redirect the user to the login page, so to be quickly able to see the page that is needing the current viewer.

Taking inspiration from the proposed patch, while landing from Tallinn to Milano, I was able to have something working here:

https://we.phorge.it/D25621

Any feedback from WMF Phabricator super-appreciated. For example, at the moment we don't show any scary warning, and we don't log anything. We just redirect to the login page if any specific components requires the current viewer.

Does it sound OK for you?

@valerio.bozzolan: Thanks for working on this! Currently a bit busy with other more urgent stuff but I hope to have time to play with it soon

valerio.bozzolan added a parent task: T356384: Phorge (Phabricator) Code Sprint 2024.May 7 2024, 4:51 PM

valerio.bozzolan mentioned this in T356384: Phorge (Phabricator) Code Sprint 2024.May 8 2024, 7:30 AM

Aklapper removed Aklapper as the assignee of this task.May 9 2024, 11:09 AM

In T217984#9778238, @valerio.bozzolan wrote:

Does it sound OK for you?

I am basically fine with everything that makes our downstream error logs less noisy. :)
Thanks for looking into this, makes sense to me. Small review comment in upstream.

valerio.bozzolan awarded a token.May 9 2024, 11:54 AM

fox_dance