Useragent should be added to Mediawiki requests saying that this is from the termbox.
It may be possible to cheaply add the version. If so we could do this but we shouldn't spend loads of time on it. For example https://stackoverflow.com/a/36733261/5576051 suggests that we could use:
import {version} from './package.json';
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| User-Agent | wikibase/termbox | master | +12 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T214899 Deploying Wikidata Termbox | |||
| Open | None | T214901 Show mobile termbox on Wikidata item and property pages | |||
| Resolved | Tarrow | T214902 Show mobile termbox on Wikidata test wiki | |||
| Resolved | Tarrow | T209961 node SSR - mediawiki (wb) HTTP request follow-up [2*2h] | |||
| Resolved | • Matthias_Geisler_WMDE | T218054 Add UA to node -> mediawiki requests |
It adds a level of indirection but the blubber.version should be realatively readily available and is a form of pinning that already is performed (i.e. no extra effort)
At this stage we would be introducing logging that is not being read by anyone. This ticket is only about adding a line of meta data to the requests we send.
Change 508499 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] User-Agent
Hey maybe a tiny question but with probably big consequences:
As Jakob pointed out, it is good to be stick on the User-Agent policy[ 1 ] of Mediawiki. That also means we have to make smaller changes to the package.json and fill it with the author field[ 2 ]. So what are the correct values for name, email, url?
[ 1 ]: https://meta.wikimedia.org/wiki/User-Agent_policy
[ 2 ]: https://flaviocopes.com/package-json/#author
The author field for WikibaseLexeme (from extension.json not package.json) for example is "The Wikidata team". This might suffice?