Page MenuHomePhabricator

Add Timeout to node -> mediawiki Requests
Closed, ResolvedPublic3 Estimated Story Points

Description

Lets configure our axios instance with a timeout. This should help reduce the risk of our service keeping growing connection count and then falling over.

This should not be shorter than the mediawiki -> node request, configured in T215912, so that we don't end too early.

Could also be related to: T217035

Note:
The timeout for the mediawiki->node request before T215912 is the default given by: $wgHTTPTimeout which is 25s.

Technical notes:

  • this should configure only the server-side http requests (not the client)
  • should be configurable via .env; falls back to a default if not configured
  • see https://github.com/axios/axios#axioscreateconfig for axios timeout configuration
  • should be set to the same default as the mediawiki -> node request timeout (3s)

Event Timeline

Lea_WMDE set the point value for this task to 3.Mar 13 2019, 3:30 PM
Lea_WMDE added a subscriber: Lea_WMDE.

It would probably make sense to have the same time out for both directions.

Change 506392 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introducing Timeout for server->MW requests

https://gerrit.wikimedia.org/r/506392

Change 506392 merged by jenkins-bot:
[wikibase/termbox@master] Introducing Timeout for server->MW requests

https://gerrit.wikimedia.org/r/506392

Change 507798 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] server: consolidate config validation

https://gerrit.wikimedia.org/r/507798

Change 507798 merged by jenkins-bot:
[wikibase/termbox@master] server: consolidate config validation

https://gerrit.wikimedia.org/r/507798