Page MenuHomePhabricator
Create Task
Maniphest T218081

Log failed node -> mediawiki requests
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Rather than needing to dig these out of Hadoop it would be easier if we logged these to logstash.

The service-runner provides a configured logging object which will write to logstash. We should use this to log the failed requests for:

  • Special:EntityData
  • Messages
  • ContentLanguages

Note: abnormally long-running requests are not to be additionally logged

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+1 -1Update termbox
wikibase/termboxmaster+59 -27Log invalid requests
wikibase/termboxmaster+174 -135Add context to errors to allow for more centralized logging
wikibase/termboxmaster+219 -67Introduce and use AxiosErrorLogger
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tarrow created this task.Mar 12 2019, 9:58 AM
Tarrow mentioned this in T209961: node SSR - mediawiki (wb) HTTP request follow-up [2*2h].
Tarrow updated the task description. (Show Details)Mar 12 2019, 12:23 PM
Tarrow updated the task description. (Show Details)
Tarrow removed Tarrow as the assignee of this task.Mar 12 2019, 2:21 PM
Lea_WMDE added a subscriber: Lea_WMDE.Mar 13 2019, 3:37 PM

This should be rewritten to log all failed requests in the central logging instance and not just the there mentioned requests. The ticket is about making it more convenient to not dig through existing logging, and it would also be able to log requests that never made it back out to mediawiki.

Lea_WMDE removed projects: Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10.Mar 13 2019, 3:38 PM
Lea_WMDE added a project: Wikidata-Termbox.
Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.
Lydia_Pintscher added a project: Wikidata.Mar 19 2019, 7:42 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:05 PM
• Pablo-WMDE updated the task description. (Show Details)Apr 17 2019, 1:25 PM
WMDE-leszek updated the task description. (Show Details)May 8 2019, 2:55 PM
WMDE-leszek set the point value for this task to 3.
Jakob_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.May 9 2019, 10:36 AM
Tarrow updated the task description. (Show Details)May 9 2019, 3:40 PM
Addshore added a comment.May 14 2019, 8:12 PM

Maybe use a log channel like Wikibase.TermboxSSR. c.f. Wikibase.NewItemIdFormatter extensions/Wikibase/repo/WikibaseRepo.datatypes.php:383

So, a while ago we synced all of the wikibase log messages to the "Wikibase" log channel, it looks like we missed / didn't migrate Wikibase.NewItemIdFormatter at the time.

For the SSR it should probably use a different log channel though. "Wikibase.TermboxSSR" sounds good though

WMDE-leszek edited projects, added Wikidata-Termbox-Iteration-16; removed Wikidata-Termbox.May 20 2019, 10:43 AM
Jakob_WMDE updated the task description. (Show Details)May 21 2019, 1:52 PM
WMDE-leszek added a project: Wikidata-Termbox-Iteration-17.Jun 3 2019, 10:39 AM
Tarrow claimed this task.Jun 3 2019, 1:59 PM
Tarrow moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-17 board.
gerritbot added a comment.Jun 4 2019, 5:19 PM

Change 514357 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] DNM - Start of logging failed requests

https://gerrit.wikimedia.org/r/514357

gerritbot added a project: Patch-For-Review.Jun 4 2019, 5:19 PM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 6 2019, 9:16 AM
Tarrow moved this task from Peer Review to Doing on the Wikidata-Termbox-Iteration-17 board.Jun 12 2019, 8:07 AM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-17 board.Jun 14 2019, 2:15 PM
gerritbot added a comment.Jun 14 2019, 6:24 PM

Change 514357 merged by jenkins-bot:
[wikibase/termbox@master] Introduce and use AxiosErrorLogger

https://gerrit.wikimedia.org/r/514357

• Pablo-WMDE added a comment.Jun 15 2019, 7:27 AM

With this deployed (T225858) to beta we can now witness verbose information in the logs, e.g. a crafted mismatch of entity id to revision id:
https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2019.06.15/wikibase-termbox?id=AWtaAdp6AbPxH_Ymzz-o&_g=()

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-17 board.Jun 17 2019, 11:25 AM
Jakob_WMDE added a subscriber: Jakob_WMDE.

It's beautiful!!

Jakob_WMDE moved this task from Done to To Do on the Wikidata-Termbox-Iteration-17 board.Jun 17 2019, 11:33 AM
WMDE-leszek added a project: Wikidata-Termbox-Iteration-18.Jun 17 2019, 11:35 AM
Jakob_WMDE claimed this task.Jun 18 2019, 9:32 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-18 board.
gerritbot added a comment.Jun 18 2019, 2:13 PM

Change 517655 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Add context to errors to allow for more centralized logging

https://gerrit.wikimedia.org/r/517655

gerritbot added a comment.Jun 18 2019, 3:58 PM

Change 517685 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Log invalid requests

https://gerrit.wikimedia.org/r/517685

Tarrow moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-18 board.Jun 19 2019, 2:54 PM
gerritbot added a comment.Jun 27 2019, 11:32 AM

Change 517655 merged by jenkins-bot:
[wikibase/termbox@master] Add context to errors to allow for more centralized logging

https://gerrit.wikimedia.org/r/517655

gerritbot added a comment.Jun 28 2019, 10:24 AM

Change 517685 merged by jenkins-bot:
[wikibase/termbox@master] Log invalid requests

https://gerrit.wikimedia.org/r/517685

gerritbot added a comment.Jun 28 2019, 2:12 PM

Change 519637 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/519637

gerritbot added a comment.Jun 28 2019, 3:29 PM

Change 519637 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/519637

WMDE-leszek added a project: Wikidata-Termbox-Iteration-19.Jul 1 2019, 11:05 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-19 board.
Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-19 board.Jul 2 2019, 4:01 PM

It works!

AxiosErrors are hard to fabricate but should also work.

Tarrow closed this task as Resolved.Jul 15 2019, 8:37 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL