Page MenuHomePhabricator

Log failed node -> mediawiki requests
Open, Needs TriagePublic3 Story Points

Description

Rather than needing to dig these out of Hadoop it would be easier if we logged these to logstash.

The service-runner provides a configured logging object which will write to logstash. We should use this to log the failed requests for:

  • Special:EntityData
  • Messages
  • ContentLanguages

Note: abnormally long-running requests are not to be additionally logged

Event Timeline

Tarrow updated the task description. (Show Details)Mar 12 2019, 12:23 PM
Tarrow updated the task description. (Show Details)
Tarrow removed Tarrow as the assignee of this task.Mar 12 2019, 2:21 PM

This should be rewritten to log all failed requests in the central logging instance and not just the there mentioned requests. The ticket is about making it more convenient to not dig through existing logging, and it would also be able to log requests that never made it back out to mediawiki.

Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:05 PM
Pablo-WMDE updated the task description. (Show Details)Apr 17 2019, 1:25 PM
WMDE-leszek updated the task description. (Show Details)May 8 2019, 2:55 PM
WMDE-leszek set the point value for this task to 3.
Tarrow updated the task description. (Show Details)May 9 2019, 3:40 PM

Maybe use a log channel like Wikibase.TermboxSSR. c.f. Wikibase.NewItemIdFormatter extensions/Wikibase/repo/WikibaseRepo.datatypes.php:383

So, a while ago we synced all of the wikibase log messages to the "Wikibase" log channel, it looks like we missed / didn't migrate Wikibase.NewItemIdFormatter at the time.

For the SSR it should probably use a different log channel though. "Wikibase.TermboxSSR" sounds good though

Jakob_WMDE updated the task description. (Show Details)May 21 2019, 1:52 PM
Tarrow claimed this task.

Change 514357 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[wikibase/termbox@master] DNM - Start of logging failed requests

https://gerrit.wikimedia.org/r/514357

Change 514357 merged by jenkins-bot:
[wikibase/termbox@master] Introduce and use AxiosErrorLogger

https://gerrit.wikimedia.org/r/514357

With this deployed (T225858) to beta we can now witness verbose information in the logs, e.g. a crafted mismatch of entity id to revision id:
https://logstash-beta.wmflabs.org/app/kibana#/doc/logstash-*/logstash-2019.06.15/wikibase-termbox?id=AWtaAdp6AbPxH_Ymzz-o&_g=()

Jakob_WMDE added a subscriber: Jakob_WMDE.

It's beautiful!!

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-18 board.

Change 517655 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Add context to errors to allow for more centralized logging

https://gerrit.wikimedia.org/r/517655

Change 517685 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Log invalid requests

https://gerrit.wikimedia.org/r/517685