Page MenuHomePhabricator

AMC navigation: instrument new items in main menu
Closed, DuplicatePublic

Description

We want to track clicks to new AMC menu items

acceptance criteria

  • Schema has been updated to let analysts determine whether AMC is enabled.
  • The schema definition (currently defined in MobileFrontend) is bumped and defined inside Minerva (EventLoggingSchemas)
  • Links are added to the main menu, each of the links has a unique event-name, for the following:
  • (+) Recent changes
  • (+) Special pages
  • (+) Community portal

QA steps

Verify events show for all the newly added items, but also the existing items.

  • Main page
  • Nearby
  • Random
  • User page/logout
  • Watchlist
  • Contributions
  • Settings

Developer notes

    • MainMenuClickTracking schema ID exists in MobileFrontend. We should move that to Minerva as this is confusing but apart from that all code is in Minerva.
  • All the code for communicating with EventLogging lives in Minerva resources/skins.minerva.scripts/menu/schema.js
  • 50% of clicks in the main menu are sampled (Per wgMinervaSchemaMainMenuClickTrackingSampleRate)
  • Every link inside the MainMenu will be logged provided it has a event-name value (see resources/skins.minerva.scripts/menu/MainMenu.js)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 10:06 AM
ovasileva renamed this task from Instrument additions to main menu to AMC navigation: instrument new items in main menu.Mar 12 2019, 10:06 AM
ovasileva triaged this task as High priority.
ovasileva moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

@ovasileva the work involved here is too trivial, I've folded it into T216152. It would be silly to do these separately.