Page MenuHomePhabricator

Update “Android theme guidelines“ page
Closed, ResolvedPublic

Event Timeline

(...) you can find all those files on this path app/src/main/res/values/. You can also find the most recent master branch on our github project repository :https://github.com/wikimedia/apps-android-wikipedia/tree/master/app/src/main/res/values there are many other xmls there as will other than the ones related to colors and styles. The ones you need there are: colors.xml for color hex definitions, attrs.xml : color groups/attributes list, their corresponding mode definitions in : styles_light.xml, styles_sepia.xml, styles_dark.xml, styles_black.xml

Hi @Sharvaniharan, per our discussion in T214504#5011905, T214504#5014742 and on a call, here’s a dedicated task for updating the theme guidelines page. I already took a crack at it:

https://www.mediawiki.org/wiki/Wikimedia_Apps/Android_theme_guidelines

LMK what you think @Sharvaniharan I got a bit confused along the way of updating that page. It seems like some colors are defined in styles.xml too? Happy to jump on a call to further discuss it.

CC @Dbrant @cooltey @Charlotte

Hey @Sharvaniharan, we’re currently using two different variables to define pure white (#fff) in the guidelines. Can we decide to call it white instead of base100 everywhere in the app?

It would also make sense to change it for #000. In this case we’d replace all instances of base0 with black.

It’s more clear and easier to read. I’ll update the theme page once you’ve updated in the code. Thanks.

Pinging @Sharvaniharan, do you still plan to make the changes mentioned in the comment above? (T218102#5020400)

I think it would be great further streamline our language! Feel free to grab the task and put it in your stack if you’re interested.

Hey @Sharvaniharan, I added new name suggestions for the color attributes to the theme guidelines page:

https://www.mediawiki.org/wiki/Wikimedia_Apps/Android_theme_guidelines

You’ll see an additional column (“New attribute name“). The suggested new names (color_group_x) are not very creative but I think it takes away the pain of coming up with a name while still establishing a common (color) language.

Next steps:

  • If you, @Dbrant and @cooltey agree with it, please update the color names in the app code
  • Once the name’s have been updated in the code, we can remove the old attribute names from the guidelines page and use the new ones (color_group_x)

Thanks for your feedback.

Charlotte lowered the priority of this task from Medium to Low.Jul 22 2019, 9:06 AM