Page MenuHomePhabricator
Create Task
Maniphest T218163

[betalabs] EditAttemptStep has undeclared properties
Closed, ResolvedPublic
Actions

Description

On betalabs when a new user opens VE the Console EditAttemptStep schema events will display several undeclared properties:
The full stack of EditAttemptStep includes errors and the events that have been successfully validated:

EventLogging Validation: [EditAttemptStep] Undeclared property "init_message"
EventLogging Validation: [EditAttemptStep] Undeclared property "loaded_type" 
EventLogging Validation: [EditAttemptStep] Undeclared property "loaded_mechanism" 
EventLogging Validation: [EditAttemptStep] Undeclared property "loaded_message"

EditAttemptStep 
{…}event: Object { version: 1, action: "loaded", is_oversample: true, … }
​
revision: 18530416
​
schema: "EditAttemptStep"
​
webHost: "en.wikipedia.beta.wmflabs.org"
​
wiki: "enwiki"

EventLogging Validation: [EditAttemptStep] Undeclared property "ready_type" 
EventLogging Validation: [EditAttemptStep] Undeclared property "ready_mechanism" 
EventLogging Validation: [EditAttemptStep] Undeclared property "ready_message"
​
EditAttemptStep 
{…}
​
event: Object { version: 1, action: "ready", is_oversample: true, … }
​
revision: 18530416
​
schema: "EditAttemptStep"
​
webHost: "en.wikipedia.beta.wmflabs.org"
​
wiki: "enwiki"

The following properties are not listed on https://meta.wikimedia.org/wiki/Schema:EditAttemptStep.

init_message
loaded_type
loaded_mechanism
loaded_message

ready_type
ready_mechanism
ready_message

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Apply EditAttemptStep validation tweaksmediawiki/extensions/MobileFrontendmaster+16 -6
schemaEditAttemptStep: fix variable name in code from VEmediawiki/extensions/MobileFrontendmaster+3 -3
trackSubscriber: don't populate all fields, to make validation happymediawiki/extensions/VisualEditormaster+12 -3
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Mar 12 2019, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 9:54 PM
JTannerWMF subscribed.EditedMar 19 2019, 6:01 PM

@Etonkovidova will update ticket with which editor and which console command this came from.

JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Mar 19 2019, 6:01 PM
JTannerWMF moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova added a project: VisualEditor.Mar 19 2019, 8:00 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova moved this task from QA to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.
In T218163#5037384, @JTannerWMF wrote:

@Etonkovidova will update ticket with which editor and which console command this came from.

Done.

JTannerWMF removed a project: Growth-Team (Sprint 0 (Growth Team)).Mar 20 2019, 5:58 PM
JTannerWMF assigned this task to DLynch.Mar 26 2019, 3:30 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.
JTannerWMF added a subscriber: DLynch.

@DLynch will investigate this further.

DLynch added a comment.Mar 27 2019, 3:28 PM

Looking at it... I think we've just always been pouring all of these in, and letting the schema accept the ones it knows about. I believe that it just discards the unknown properties, rather than the entire event in those cases, right?

I admit to not understanding why we did that foo_type thing in the first place, as opposed to just having type and using the existing action field to filter it. 🤷‍♂️

Still, I can probably knock up a quick patch to whitelist which of the action-types need those properties.

gerritbot added a comment.Apr 1 2019, 4:58 PM

Change 500491 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] trackSubscriber: don't populate all fields, to make validation happy

https://gerrit.wikimedia.org/r/500491

gerritbot added a project: Patch-For-Review.Apr 1 2019, 4:58 PM
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 1 2019, 5:06 PM
matmarex subscribed.Apr 1 2019, 9:44 PM

I don't see the validation messages in the console, even with trackdebug=1. How do I reproduce this?

DLynch added a comment.Apr 2 2019, 2:44 PM

@matmarex: see debug.js in the EventLogging extension for more details, but basically, do this in your console:

mw.loader.using( 'mediawiki.api' ).then( function () {
    new mw.Api().saveOption( 'eventlogging-display-web', '1' );
} );

Then you'll need to actually make the event happen, which trackdebug doesn't do (in fact, it suppresses the actual event to avoid distorting the sample with debug actions). If you install the WikimediaEvents extension, you can then stick $wgWMESchemaEditAttemptStepSamplingRate = 1; into a config file and it'll just log everything.

gerritbot added a comment.Apr 3 2019, 1:18 PM

Change 500491 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] trackSubscriber: don't populate all fields, to make validation happy

https://gerrit.wikimedia.org/r/500491

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 2:02 PM
DLynch moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 3 2019, 3:38 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:32 PM
JTannerWMF added a project: Skipped QA.May 23 2019, 7:03 PM
ppelberg closed this task as Resolved.May 24 2019, 11:12 PM
gerritbot added a comment.Jun 7 2019, 11:12 PM

Change 515235 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] Apply EditAttemptStep validation tweaks

https://gerrit.wikimedia.org/r/515235

gerritbot added a project: Patch-For-Review.Jun 7 2019, 11:12 PM
Krinkle subscribed.Jun 8 2019, 12:13 AM
In T218163#5062379, @DLynch wrote:

Looking at it... I think we've just always been pouring all of these in, and letting the schema accept the ones it knows about. I believe that it just discards the unknown properties, rather than the entire event in those cases, right? [..]

EventLogging discards invalid events, and it uses the same logic as the validation that EventLogging's debug mode performs in the browser.

See https://logstash.wikimedia.org/goto/0dcde09a5b2da057fffedbd0773bd3ca for timeline of these with samples of discarded events.

gerritbot added a comment.Jun 8 2019, 7:14 PM

Change 515235 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Apply EditAttemptStep validation tweaks

https://gerrit.wikimedia.org/r/515235

gerritbot added a comment.Jun 8 2019, 10:27 PM

Change 515867 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: fix variable name in code from VE

https://gerrit.wikimedia.org/r/515867

gerritbot added a comment.Jun 9 2019, 9:31 PM

Change 515867 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep: fix variable name in code from VE

https://gerrit.wikimedia.org/r/515867

matmarex merged a task: T215962: [betalabs] "EventLogging Validation: [EditAttemptStep] Undeclared property " errors.Feb 5 2020, 1:18 AM
matmarex added a subscriber: Catrope.
Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 2:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits