[Bug/Regression] New talk topic edits are lost when I click browser back button
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 12 2019, 11:19 PM

Description

tldr: onBeforeExit doesn't run when clicking back button meaning edits can be lost. This relates to the changes in T217102.

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk while logged in
Click add discussion
Type some text in subject
Click browser back button
Say "cancel" to the dialog that shows

Expected: I do not leave the overlay and keep my edits
Actual: I leave the overlay and lose my edits

A similar but less severe problem exists in the editor. When opening the editor, entering text and clicking browser back the URL is lost. Clicking back and leave can take them out the site.

QA steps (passed)

Test on Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

Talk

Visit a page and click talk button
Click add discussion
Type some text in the textarea
Click the close icon in the top left corner
Confirmation message appears. Click continue editing
Confirm you stay in the overlay, the URL remains #/talk/new
Type text in textarea
Press browser back button
Confirm you stay in the overlay, the URL remains #/talk/new

QA (failed)

The following QA step failed and has been pulled into its own bug : T218809

Editor

Visit a page and click edit
Type some text in the textarea
Click the close icon in the top left corner
Confirmation message appears. Click continue editing
Confirm you stay in the overlay, the URL remains #/editor/0
Type text in textarea
Press browser back button
Confirm you stay in the overlay, the URL remains #/editor/0

Details

	Subject	Repo	Branch	Lines +/-
	onBeforeExit is also run on browser back/forward buttons	mediawiki/extensions/MobileFrontend	master	+64 -18
	Overlays are rendered inside a container	mediawiki/extensions/MobileFrontend	master	+14 -16

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved		Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved		Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Open		None	T281930 [EPIC] Migrate MobileFrontend's code to Vue.js and Codex
Open		None	T212465 [EPIC] None of our View's should exhibit 2 levels of inheritance
Declined		Jdlrobson	T217102 MFA: TalkSectionAddOverlay should use Overlay.make pattern
Resolved	BUG REPORT	Jdlrobson	T218173 [Bug/Regression] New talk topic edits are lost when I click browser back button

Event Timeline

Jdlrobson created this task.Mar 12 2019, 11:19 PM

Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 12 2019, 11:35 PM

Jdlrobson renamed this task from [Bug/Regression] TalkOverlay edits are lost when I click browser back button to [Bug/Regression] New talk topic edits are lost when I click browser back button.Mar 13 2019, 12:27 AM

Jdlrobson updated the task description. (Show Details)

Change 496081 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] onBeforeExit is also run on browser back/forward buttons

https://gerrit.wikimedia.org/r/496081

gerritbot added a project: Patch-For-Review.Mar 13 2019, 12:30 AM

Note https://gerrit.wikimedia.org/r/496081 doesn't fix the problem, but blocks me making the fix!

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 13 2019, 1:01 AM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 14 2019, 12:15 AM

Change 496354 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Overlays are rendered inside a container

https://gerrit.wikimedia.org/r/496354

ovasileva mentioned this in T217643: Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias.Mar 18 2019, 12:24 PM

Change 496354 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Overlays are rendered inside a container

https://gerrit.wikimedia.org/r/496354

Jdlrobson updated the task description. (Show Details)Mar 19 2019, 1:22 AM

Change 496081 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] onBeforeExit is also run on browser back/forward buttons

https://gerrit.wikimedia.org/r/496081

Jdlrobson assigned this task to Edtadros.Mar 19 2019, 1:57 AM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 19 2019, 2:02 PM

Test Result

Status: ❌ Fail
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

Editor: ❌ FAIL

Visit a page and click edit
Type some text in the textarea
Click the close icon in the top left corner
Confirmation message appears. ✅
Click continue editing
Confirm you stay in the overlay, the URL remains #/editor/0 ✅
Type text in textarea
Press browser back button
Confirm you stay in the overlay, the URL remains #/editor/0 ❌

Screen Shot 2019-03-19 at 10.20.29 PM.png (1×946 px, 295 KB)

The url changes to: https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

Screen Shot 2019-03-19 at 10.39.19 PM.png (2×1 px, 862 KB)

Talk : ✅ PASS

Visit a page and click talk button
Click add discussion
Type some text in the textarea
Click the close icon in the top left corner
Confirmation message appears. Click continue editing ✅

Screen Shot 2019-03-19 at 10.30.36 PM.png (2×1 px, 653 KB)

Confirm you stay in the overlay, the URL remains #/talk/new ✅

Screen Shot 2019-03-19 at 10.32.01 PM.png (2×1 px, 650 KB)

Type text in textarea
Press browser back button
Confirm you stay in the overlay, the URL remains #/talk/new ✅

Screen Shot 2019-03-19 at 10.31.51 PM.png (2×1 px, 651 KB)

Confirm you stay in the overlay, the URL remains #/editor/0 ❌

Moved this out into T218809 since it requires significantly more work to fix. This task is ready for sign off now.

resolving

	F28424148: Screen Shot 2019-03-19 at 10.20.29 PM.png
	Mar 20 2019, 5:40 AM

	F28424177: Screen Shot 2019-03-19 at 10.30.36 PM.png
	Mar 20 2019, 5:40 AM

	F28424188: Screen Shot 2019-03-19 at 10.39.19 PM.png
	Mar 20 2019, 5:40 AM

	F28424179: Screen Shot 2019-03-19 at 10.32.01 PM.png
	Mar 20 2019, 5:40 AM

	F28424181: Screen Shot 2019-03-19 at 10.31.51 PM.png
	Mar 20 2019, 5:40 AM

[Bug/Regression] New talk topic edits are lost when I click browser back buttonClosed, ResolvedPublicBUG REPORTActions