Properly handle (=disallow) imports
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	hoo
	Mar 13 2019, 2:41 AM

Description

Similar to Wikibase, we should probably have proper handling for imports (from another wiki or from XML files), otherwise imported Schemas might have conflicting IDs. Also the entity id assigning would need to be updated after each import in order not to run into already existing Schema IDs (AFAIR wikibase currently doesn't handle that).

For Wikibase this currently means that there is a setting allowEntityImport (defaulting to false) which toggles whether it's possible to import into the Wikibase namespace.

Details

Subject	Repo	Branch	Lines +/-
Prevent import of Schema revisions	mediawiki/extensions/WikibaseSchema	master	+19 -1
Restrict Schema namespace to Schema content	mediawiki/extensions/WikibaseSchema	master	+24 -1
Restrict Schema content to Schema namespace	mediawiki/extensions/WikibaseSchema	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T219313: Prevent moving Schema pages

Event Timeline

hoo created this task.Mar 13 2019, 2:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2019, 2:41 AM

For WikibaseSchema I wouldn’t even make this configurable, just disabling it unconditionally should be fine.

Lydia_Pintscher moved this task from Backlog to Needs work on the EntitySchema board.Mar 13 2019, 7:43 PM

Not required for initial deployment, since only very few users have the rights to import and there’s not really any place where they could import Schemas from.

Lucas_Werkmeister_WMDE claimed this task.Mar 26 2019, 5:59 PM

Lucas_Werkmeister_WMDE edited projects, added Shape Expressions Sprint 5; removed EntitySchema.

Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 5 board.

Change 499300 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema content to Schema namespace

https://gerrit.wikimedia.org/r/499300

Change 499301 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema namespace to Schema content

https://gerrit.wikimedia.org/r/499301

Change 499302 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Prevent import of Schema revisions

https://gerrit.wikimedia.org/r/499302

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Shape Expressions Sprint 5 board.Mar 26 2019, 6:57 PM

Lucas_Werkmeister_WMDE mentioned this in T219313: Prevent moving Schema pages.

hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 5 board.Mar 27 2019, 10:01 AM

Change 499300 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema content to Schema namespace