Page MenuHomePhabricator

Properly handle (=disallow) imports
Closed, ResolvedPublic3 Story Points

Description

Similar to Wikibase, we should probably have proper handling for imports (from another wiki or from XML files), otherwise imported Schemas might have conflicting IDs. Also the entity id assigning would need to be updated after each import in order not to run into already existing Schema IDs (AFAIR wikibase currently doesn't handle that).

For Wikibase this currently means that there is a setting allowEntityImport (defaulting to false) which toggles whether it's possible to import into the Wikibase namespace.

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseSchema : masterPrevent import of Schema revisions
mediawiki/extensions/WikibaseSchema : masterRestrict Schema namespace to Schema content
mediawiki/extensions/WikibaseSchema : masterRestrict Schema content to Schema namespace

Event Timeline

hoo created this task.Mar 13 2019, 2:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2019, 2:41 AM

For WikibaseSchema I wouldn’t even make this configurable, just disabling it unconditionally should be fine.

Lucas_Werkmeister_WMDE set the point value for this task to 3.

Not required for initial deployment, since only very few users have the rights to import and there’s not really any place where they could import Schemas from.

Change 499300 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema content to Schema namespace

https://gerrit.wikimedia.org/r/499300

Change 499301 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema namespace to Schema content

https://gerrit.wikimedia.org/r/499301

Change 499302 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Prevent import of Schema revisions

https://gerrit.wikimedia.org/r/499302

Change 499300 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema content to Schema namespace

https://gerrit.wikimedia.org/r/499300

Change 499301 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Restrict Schema namespace to Schema content

https://gerrit.wikimedia.org/r/499301

Change 499302 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Prevent import of Schema revisions

https://gerrit.wikimedia.org/r/499302

Lydia_Pintscher closed this task as Resolved.Apr 10 2019, 11:00 AM
Lydia_Pintscher moved this task from Verification to Done on the Shape Expressions Sprint 5 board.

\o/