Page MenuHomePhabricator

Layout block is duplicated with custom layout at beginning of tag
Closed, ResolvedPublic

Description

<score>
\layout { indent = 0 } \new Score { \new Staff { \relative c, { \time 4/4 \key d \major \clef "bass_8" \omit Staff.ClefModifier \tempo 2 = 60 \omit Score.MetronomeMark \bar "" fis2\p( g4 a) | a4( g fis e) | d2( e4 fis) | fis4.( e8) e2 } } }</score>

Without the line break after <score>, the entire score is duplicated; replicated on wikidata.beta.wmflabs.org (see T218191#5020310).

Wikibase does not allow line breaks in strings. This may be problematic in some cases, since the design of the interface would encourage users to add \layout or similar code for cosmetic rather than functional reasons. It might be possible to resolve this by adding a line break in the template used for generating scores.

Event Timeline

Jc86035 created this task.Mar 13 2019, 11:17 AM
Jc86035 updated the task description. (Show Details)
Jc86035 updated the task description. (Show Details)
Jc86035 updated the task description. (Show Details)Mar 13 2019, 11:20 AM
Jc86035 updated the task description. (Show Details)
Jc86035 updated the task description. (Show Details)

Change 496157 had a related patch set uploaded (by Ebe123; owner: Ebe123):
[mediawiki/extensions/Score@master] Fix score duplication due to double layout blocks

https://gerrit.wikimedia.org/r/496157

Ebe123 claimed this task.
Ebe123 renamed this task from Line break issues with certain scores to Layout block is duplicated with custom layout at beginning of tag.

Change 496157 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Fix score duplication due to double layout blocks

https://gerrit.wikimedia.org/r/496157

Ebe123 closed this task as Resolved.Mar 13 2019, 7:10 PM

Should the fix be backported before today’s release of the musical notation datatype on Wikidata?