Page MenuHomePhabricator
Create Task
Maniphest T218223

Upgrade script from MW 1.29 to 1.32 seems to break revision table
Open, Needs TriagePublicBUG REPORT
Actions

Description

Recently installed MW 1.32 in parallel with 1.29. (Site has less than 50 pages and around 300 revisions total.) Ran the update script. 1.29 instance still works fine, but on 1.32 around 20% of pages crash with an error related to missing revision ids in the database.

Steps to Reproduce:

  • Install MW 1.29.
  • Make a half dozen edits to several pages.
  • Backup the database.
  • Install MW 1.32 in parallel.
  • Run update.php.
  • Navigate to edited pages. Several of them should fail to load, with an error related to their revision ids not being found in the database.

Actual Results:
Approximately 20% of pages give the following error (with $wgShowExceptionDetails enabled):

Original exception: [long hash] /wiki/index.php/Main_Page MediaWiki\Revision\RevisionAccessException from line 1635 of /var/www/html/wiki/includes/Revision/RevisionStore.php: Main slot of revision 296 not found in database!

Expected Results:
Pages should load properly.

Temporary Fix:
Add to LocalSettings.php either:

  • $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_OLD;, or
  • $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD;

Both will work.

Happy to provide database sql file for reproduction.

Related Objects

Event Timeline

Kaldenderfer created this task.Mar 13 2019, 3:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2019, 3:48 PM
Addshore added a project: Multi-Content-Revisions.Mar 13 2019, 5:29 PM
Ciencia_Al_Poder subscribed.Mar 14 2019, 10:17 AM
daniel claimed this task.Mar 19 2019, 2:50 PM
daniel added projects: Platform Engineering (MCR), Platform Team Workboards.
daniel moved this task from Not a real column to Ready on the Platform Team Workboards board.
daniel added a comment.EditedMar 20 2019, 2:04 PM

I have a few questions:

  • does the error always occur on the same pages, or does it happen "sometimes"?
  • does the error happen on revisions created before the update, or revisions created after the update, or both?
  • does the updatelog table contain an entry that related to PopulateContentTables or populateContentTables.php?
  • does running maintenance/populateContentTables.php fix the issue? Please make a DB dump before you try this, so we have a chance to see what the problem was.
daniel added a project: User-Daniel.Mar 20 2019, 2:05 PM
• CCicalese_WMF moved this task from Inbox to Reactive on the Multi-Content-Revisions board.Mar 26 2019, 4:32 PM
• CCicalese_WMF edited projects, added: Multi-Content-Revisions (Reactive); removed: Multi-Content-Revisions.
• kchapman moved this task from Ready to Blocked Externally on the Platform Team Workboards board.Apr 1 2019, 1:25 PM
• kchapman edited projects, added: Platform Team Workboards (Blocked Externally); removed: Platform Team Workboards.
• kchapman subscribed.

Blocked until a reply from @Kaldenderfer to answer our questions.

Aklapper changed the task status from Open to Stalled.Apr 5 2019, 12:13 PM

[Blocked means stalled task status](https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle) hence setting that.

• CCicalese_WMF edited projects, added: Platform Team Legacy (Watching / External); removed: Platform Team Workboards (Blocked Externally).May 13 2019, 3:11 PM
• CCicalese_WMF removed a project: Platform Team Legacy (Watching / External).Jul 26 2019, 5:43 PM
• WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:37 PM
• WDoranWMF edited projects, added: Core Platform Team Initiatives (MCR); removed: Platform Engineering (MCR).
Kghbln updated the task description. (Show Details)Feb 14 2020, 8:22 AM
Kghbln subscribed.EditedFeb 15 2020, 12:45 AM

In my case I had several complications which may have triggered the issue. A little wiki farm with shared tables and only the option to use the webupdater. Luckily the hosting was changed in the meantime.

does the error always occur on the same pages, or does it happen "sometimes"?

sometimes, i.e. the pages with borked database data as indicated in the report

does the error happen on revisions created before the update, or revisions created after the update, or both?

only before

does the updatelog table contain an entry that related to PopulateContentTables or populateContentTables.php?

Yes, it does, however unsure if added by update.php or populateContentTables.php

does running maintenance/populateContentTables.php fix the issue?

Yes, it does, which is good.

Aklapper changed the task status from Stalled to Open.Nov 5 2020, 11:55 AM

Questions have been answered hence resetting task status.

Aklapper removed daniel as the assignee of this task.Jul 2 2021, 5:11 AM
Aklapper added a subscriber: daniel.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

BPirkle mentioned this in T286578: MediaWiki update.php forgot to populate slot_roles.Jul 13 2021, 8:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits