Page MenuHomePhabricator
Create Task
Maniphest T218254

EventBus extension should never log unserialized events
Closed, ResolvedPublic
Actions

Description

THe Event-Platform extension should only log serialized events to avoid blowing up logstash indexing.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Only log serialized size-limited events.mediawiki/extensions/EventBusmaster+25 -15
Send serialized event in error log and truncate if to bigmediawiki/extensions/EventBusmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Mar 13 2019, 8:36 PM
Restricted Application added a project: Analytics. · View Herald TranscriptMar 13 2019, 8:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• mobrovac edited projects, added Platform Team Workboards (Doing), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)); removed Platform Team Workboards.Mar 13 2019, 8:47 PM
gerritbot subscribed.Mar 13 2019, 8:48 PM

Change 496261 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[mediawiki/extensions/EventBus@master] Send serialized event in error log and truncate if to big

https://gerrit.wikimedia.org/r/496261

gerritbot added a project: Patch-For-Review.Mar 13 2019, 8:48 PM
• Pchelolo added a parent task: T218255: Enabling api-request eventgate to group1 caused minor service disruptions .Mar 13 2019, 9:05 PM
gerritbot added a comment.Mar 14 2019, 2:35 PM

Change 496449 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Only log serialized size-limited events.

https://gerrit.wikimedia.org/r/496449

gerritbot added a comment.Mar 14 2019, 2:51 PM

Change 496261 abandoned by Ottomata:
Send serialized event in error log and truncate if to big

Reason:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/ /496449/ is better.

https://gerrit.wikimedia.org/r/496261

gerritbot added a comment.Mar 14 2019, 2:54 PM

Change 496449 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Only log serialized size-limited events.

https://gerrit.wikimedia.org/r/496449

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 3:04 AM
Milimetric triaged this task as High priority.Mar 18 2019, 3:35 PM
Milimetric added a project: Analytics-Kanban.
Milimetric moved this task from Incoming to Event Platform on the Analytics board.
Ottomata moved this task from Backlog to To be Estimated/To be discussed on the Event-Platform board.Mar 25 2019, 6:36 PM
Ottomata closed this task as Resolved.Mar 25 2019, 7:03 PM
• mobrovac edited projects, added Services (done), Platform Team Workboards (Done with CPT); removed Patch-For-Review, Platform Team Workboards (Doing), Services (doing).Mar 28 2019, 1:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits