Page MenuHomePhabricator

Merge blocker: TypeError: wb.tests.getMockListItemAdapter is not a function
Closed, ResolvedPublic

Description

ContentTranslation merges are blocked due to this error, for example:

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/39333/console

12:12:38 HeadlessChrome 71.0.3578 (Linux 0.0.0) WARN: 'appendToSelector will soon be a required parameter to OverlayManager'
12:12:38 HeadlessChrome 71.0.3578 (Linux 0.0.0) LOG: 'Exception in module-execute in module WikibaseLexeme.tests:'
12:12:38 HeadlessChrome 71.0.3578 (Linux 0.0.0) WARN: TypeError: wb.tests.getMockListItemAdapter is not a function
12:12:38 TypeError: wb.tests.getMockListItemAdapter is not a function
12:12:38     at http://localhost:9876/load.php?debug=false&lang=en&modules=ContentTranslation%20v2%20test%20suite%2Ccolor-picker%2CdataValues%2CdiffMatchPatch%2Cdompurify%2Cjquery%7CWikibaseLexeme.tests%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralauth.ForeignApi%7Cext.cite.style%2Cstyles%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%2Cicons%2Ctest%7Cext.cx.model%2Csitemapper%2Ctranslation%2Cutil%7Cext.cx.sitemapper.test%7Cext.cx.tools.card%2Ccategories%2Cmanager%2Cmtabuse%2Ctests%2Cvalidator%7Cext.cx.translation.loader%2Cprogress%2Ctests%7Cext.cx.translation.loader.test%7Cext.cx.util.selection%7Cext.echo.api%2Cdm%7Cext.echo.dm.tests%7Cext.eventLogging%7Cext.eventLogging.debug%7Cext.guidedTour.lib%2Cstyles%7Cext.guidedTour.lib.internal%2Ctests%7Cext.templateData.test%7Cext.templateDataGenerator.data%7Cext.uls.common%2Ci18n%2Cinit%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Ctests%7Cext.visualEditor.articleTarget%2Cbase%2CcheckList%2CcommentAnnotation%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cexperimental%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2CmoduleIndicators%2Cmwalienextension%2Cmwcore%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwtransclusion%2CprogressBarWidget%2Crebase%2Csanitize%2CsupportCheck%2Cswitching%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.desktopArticleTarget.init%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7CglobeCoordinate.js%7Cjquery.AnimationEvent%2CPurposedCallbacks%2CaccessKeyLabel%2CanimateWithEvent%2CcheckboxShiftClick%2Cclient%2Ccolor%2CcolorUtil%2Ccookie%2CfocusAt%2CgetAttrs%2ChighlightText%2Ci18n%2Cinputautoexpand%2ClengthLimit%2CmakeCollapsible%2Csuggestions%2CtabIndex%2Ctablesorter%2CtextSelection%2Cthrottle-debounce%2Ctipsy%7Cjquery.event.special.eachchange%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cjquery.ui.EditableTemplatedWidget&skin=vector&version=038ebea:257:614
12:12:38     at http://localhost:9876/load.php?debug=false&lang=en&modules=ContentTranslation%20v2%20test%20suite%2Ccolor-picker%2CdataValues%2CdiffMatchPatch%2Cdompurify%2Cjquery%7CWikibaseLexeme.tests%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralauth.ForeignApi%7Cext.cite.style%2Cstyles%2CvisualEditor%7Cext.cite.visualEditor.core%2Cdata%2Cicons%2Ctest%7Cext.cx.model%2Csitemapper%2Ctranslation%2Cutil%7Cext.cx.sitemapper.test%7Cext.cx.tools.card%2Ccategories%2Cmanager%2Cmtabuse%2Ctests%2Cvalidator%7Cext.cx.translation.loader%2Cprogress%2Ctests%7Cext.cx.translation.loader.test%7Cext.cx.util.selection%7Cext.echo.api%2Cdm%7Cext.echo.dm.tests%7Cext.eventLogging%7Cext.eventLogging.debug%7Cext.guidedTour.lib%2Cstyles%7Cext.guidedTour.lib.internal%2Ctests%7Cext.templateData.test%7Cext.templateDataGenerator.data%7Cext.uls.common%2Ci18n%2Cinit%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Ctests%7Cext.visualEditor.articleTarget%2Cbase%2CcheckList%2CcommentAnnotation%2Ccore%2Cdata%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cexperimental%2Cicons%2Clanguage%2Cmediawiki%2CmoduleIcons%2CmoduleIndicators%2Cmwalienextension%2Cmwcore%2Cmwextensionmessages%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwtransclusion%2CprogressBarWidget%2Crebase%2Csanitize%2CsupportCheck%2Cswitching%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%2Cwelcome%7Cext.visualEditor.core.desktop%7Cext.visualEditor.desktopArticleTarget.init%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core%7CglobeCoordinate.js%7Cjquery.AnimationEvent%2CPurposedCallbacks%2CaccessKeyLabel%2CanimateWithEvent%2CcheckboxShiftClick%2Cclient%2Ccolor%2CcolorUtil%2Ccookie%2CfocusAt%2CgetAttrs%2ChighlightText%2Ci18n%2Cinputautoexpand%2ClengthLimit%2CmakeCollapsible%2Csuggestions%2CtabIndex%2Ctablesorter%2CtextSelection%2Cthrottle-debounce%2Ctipsy%7Cjquery.event.special.eachchange%7Cjquery.makeCollapsible.styles%7Cjquery.tablesorter.styles%7Cjquery.ui.EditableTemplatedWidget&skin=vector&version=038ebea:259:223
12:12:38     at runScript (http://127.0.0.1:9412//index.php?title=Special:JavaScriptTest/qunit/export:13:927)
12:12:38     at execute (http://127.0.0.1:9412//index.php?title=Special:JavaScriptTest/qunit/export:15:553)
12:12:38     at doPropagation (http://127.0.0.1:9412//index.php?title=Special:JavaScriptTest/qunit/export:7:849)
12:12:38 HeadlessChrome 71.0.3578 (Linux 0.0.0) ERROR

Event Timeline

Nikerabbit triaged this task as Unbreak Now! priority.Mar 14 2019, 7:45 AM

Thanks for bringing this to our attention.

Change 496395 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] qunit: expose getMockListItemAdapter test-only module

https://gerrit.wikimedia.org/r/496395

Change 496396 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] qunit: explicitly depend on getMockListItemAdapter

https://gerrit.wikimedia.org/r/496396

Change 496399 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/ContentTranslation@master] CI, please

https://gerrit.wikimedia.org/r/496399

We are now explicitly modeling the dependency of lexeme's tests to wikibase's getMockListItemAdapter which should prevent this from reoccurring. Patches should be in master soon.

Change 496395 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] qunit: expose getMockListItemAdapter test-only module

https://gerrit.wikimedia.org/r/496395

Change 496396 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] qunit: explicitly depend on getMockListItemAdapter

https://gerrit.wikimedia.org/r/496396

Pablo-WMDE claimed this task.
Pablo-WMDE lowered the priority of this task from Unbreak Now! to Medium.

The - supposedly - blocked patch has been merged in the mean time and the two fixes resulting from this ticket have been applied to wikibase and lexeme respectively.

Change 496399 abandoned by Pablo Grass (WMDE):
CI, please

https://gerrit.wikimedia.org/r/496399