Page MenuHomePhabricator
Create Task
Maniphest T218289

Special:ManageMessageGroups gets confused after renames and thinks there are more changes
Closed, ResolvedPublic
Actions

Description

Scenario (that happened today)

  1. Repository syncing script runs (processMessageChanges.php)
  2. Go to Special:ManageMessageGroups and see that there has been message key renames
  3. Do those renames manually using Special:ReplaceText
  4. Go back to Special:ManageMessageGroups, refresh the page, and submit the changes

Observed:

  • The page shows a heading for the message group which had renames and no changes

Expected:

  • The page says "no changes to process" (or whatever is the exact wording that is normally shown)

Details

SubjectRepoBranchLines +/-
Fix ManageMessageGroups from re-appearing after submissionmediawiki/extensions/Translatemaster+13 -3
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Mar 14 2019, 12:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2019, 12:25 PM
Nikerabbit triaged this task as Low priority.Mar 14 2019, 12:27 PM

Priority is low because this is a tool used by admins only, and impact is limited to confusion (with potentially reducing trust on the tool) if the admin is not aware of this issue.

abi_ added a project: User-abi_.Mar 14 2019, 12:45 PM
abi_ subscribed.
Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Mar 18 2019, 3:15 PM
abi_ claimed this task.Apr 21 2019, 7:37 AM
abi_ moved this task from Backlog to In Progress on the User-abi_ board.
gerritbot added a comment.Apr 21 2019, 10:26 AM

Change 505453 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix ManageMessageGroups from re-appearing after submission.

https://gerrit.wikimedia.org/r/505453

gerritbot added a project: Patch-For-Review.Apr 21 2019, 10:26 AM
abi_ moved this task from In Progress to Under Review on the User-abi_ board.Apr 21 2019, 10:55 AM

This would happen even when there were no more messages to process. When rendering the page, messages that are renamed appear as changes but are ignored. They appear as changes again when the submission happens but since nothing is present regarding this message in the request body, the assumption is made that maximum number of post parameters are reached and hence loading the ManageMessageGroups page again. Fixed by adding a check during message processing.

gerritbot added a comment.May 7 2019, 7:33 AM

Change 505453 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix ManageMessageGroups from re-appearing after submission

https://gerrit.wikimedia.org/r/505453

abi_ moved this task from Under Review to QA on the User-abi_ board.May 7 2019, 7:57 AM
abi_ removed a project: Patch-For-Review.

Updating status as the patch has been merged.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 7 2019, 8:00 AM
abi_ closed this task as Resolved.May 29 2019, 7:13 PM
abi_ moved this task from QA to Done on the User-abi_ board.

Tested this on Translatewiki.net.

Renamed a bunch of messages today, and submitted. Saw the appropriate response appear,

Message definitions have been updated. Changes are being processed in the background.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL