Model ULS dependency
Open, Needs TriagePublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Pablo-WMDE
	Mar 14 2019, 12:58 PM

Description

Termbox depends on ULS but currently blindly relies on it being available.
Either express this hard dependency in some form of documentation or implement, if possible, a fallback.

Info

discovered by running termbox on a wikibase installation w/o ULS installed

Exception in module-execute in module wikibase.termbox: load.php:2:596
TypeError: "window.$.uls is undefined"

the code that serves the same purpose in wikibase implements a (rather simple) fallback behavior for the case uls is not there

Related Objects

Mentioned In: T318137: MUL - Fix mobile termbox styles for present/missing labels/descriptions
T289061: Avoid using ULS in termbox
T261488: trial new termbox on desktop on a test system
Mentioned Here: T261851: Language in Wikidata termbox shows native language names (samples: es-419, sms, nod) or language code (samples: srq, en-us) instead of localised names for some languages

Event Timeline

• Pablo-WMDE created this task.Mar 14 2019, 12:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2019, 12:58 PM

• Pablo-WMDE added subscribers: Jakob_WMDE, Tarrow, • Matthias_Geisler_WMDE.Mar 15 2019, 9:24 AM

Lydia_Pintscher added a project: Wikidata.Mar 19 2019, 7:42 PM

For the time being, hard dependency on ULS is fine from Product side. This decision is going to be revisited before using the new termbox on Desktop.

WMDE-leszek set the point value for this task to 1.Mar 20 2019, 3:13 PM

WMDE-leszek moved this task from MVP tickets: In preparation to Editing (deprioritized tickets) on the Wikidata-Termbox board.

• Pablo-WMDE updated the task description. (Show Details)Mar 20 2019, 3:54 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:04 PM

Lea_WMDE moved this task from Editing (deprioritized tickets) to Tech (deprioritized tickets) on the Wikidata-Termbox board.Apr 12 2019, 11:32 AM

• Pablo-WMDE mentioned this in T261488: trial new termbox on desktop on a test system.Oct 19 2020, 2:16 PM

• Pablo-WMDE added a project: User-Pablo-WMDE.Nov 19 2020, 8:51 AM

• Pablo-WMDE moved this task from Incoming to Short term on the User-Pablo-WMDE board.

This here is talking about the "if" (and the "what if not") while T261851#6461737 recently talked about the "how".

Michael added a project: [DEPRECATED] wdwb-tech.Apr 6 2021, 10:58 AM

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Apr 12 2021, 7:37 AM

We don’t even have a ResourceLoader dependency, so as far as I can tell, this currently works by sheer luck? Something must be loading the ULS ResourceLoader module before Termbox gets loaded.

Ladsgroup mentioned this in T289061: Avoid using ULS in termbox.Aug 17 2021, 2:30 PM

Addshore moved this task from To Prioritize to Triaged Medium (50+) on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 2:42 PM

Lucas_Werkmeister_WMDE mentioned this in T318137: MUL - Fix mobile termbox styles for present/missing labels/descriptions.Sep 23 2022, 9:30 AM

Comment added to readme: https://gerrit.wikimedia.org/r/c/wikibase/termbox/+/834051

Model ULS dependencyOpen, Needs TriagePublic1 Estimated Story PointsActions

Description

Related Objects

Event Timeline

Model ULS dependency
Open, Needs TriagePublic1 Estimated Story Points
Actions