Inline slugs visible on Chrome Mobile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Mar 14 2019, 6:09 PM

Description

This appears to be an effect of using width: 1px and a high-DPI device:

It is visible on desktop if you increase the width .ve-ce-chimera-webkit to 2px:

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (a61616907)	mediawiki/extensions/VisualEditor	master	+1 -1
Set Chrome inline slugs to 0px width instead of adding src	VisualEditor/VisualEditor	master	+8 -4
Always give inline slugs an src	VisualEditor/VisualEditor	master	+3 -4

Customize query in gerrit

Related Objects

Mentioned Here: rGVED8bb1eb5982e0: Scroll 60px past toolbar on iOS too to avoid context menu clash

Event Timeline

Esanders created this task.Mar 14 2019, 6:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2019, 6:09 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 14 2019, 6:27 PM

Change 496511 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Always give inline slugs an src

https://gerrit.wikimedia.org/r/496511

gerritbot added a project: Patch-For-Review.Mar 14 2019, 6:27 PM

Esanders claimed this task.Mar 14 2019, 6:28 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Esanders added a subscriber: dchan.

Change 496511 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Always give inline slugs an src

https://gerrit.wikimedia.org/r/496511

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 14 2019, 6:40 PM

Esanders added a project: Editing QA.

Esanders moved this task from Inbox to Low Priority on the Editing QA board.

I said on the patch that "On a featured article only 17ms total is spent in setupSlugs."

That was actually the time before this patch. I did jump from ~20ms to ~60ms on [[Barack Obama]]. That's a relatively small amount on such a large article, but it all adds up, so we should stay open to removing this again on Chrome if possible.

Change 496553 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Set Chrome inline slugs to 0px width instead of adding src

https://gerrit.wikimedia.org/r/496553

Esanders moved this task from QA to Code review on the VisualEditor (Current work) board.Mar 14 2019, 7:15 PM

Change 496473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8bb1eb598)

https://gerrit.wikimedia.org/r/496473

Change 496473 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a61616907)

https://gerrit.wikimedia.org/r/496473

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.22; 2019-03-19); removed Patch-For-Review.Mar 18 2019, 9:32 PM

Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.

Ryasmeen added a project: Verified.Mar 21 2019, 6:54 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Ryasmeen removed a project: Editing QA.Mar 21 2019, 6:56 PM

• ppelberg closed this task as Resolved.Apr 16 2019, 7:03 PM