Create RestrictionStore service
Closed, ResolvedPublic
Actions

Description

The purpose of this task is to allow application logic to determine restrictions (protection) imposed on a page given only a PageIdentity, without the need to have a Title object. RestrictionStore is to replace the usage of Title::getRestrictions in PermissionManager (see T208768) and other application logic.

Methods to be factored into the new service class:

Title::loadRestrictions
Title::loadRestrictionsFromRows should probably just be removed.
Title::getRestrictions
Title::getAllRestrictions
Title::getRestrictionExpiry
Title::getTitleProtection
Title::isSemiProtected
Title::deleteTitleProtection
Title::isProtected
Title::isNamespaceProtected - though perhaps that could go into PermissionManager
Title::isCascadeProtected
Title::getCascadeProtectionSources
perhaps other methods dealing with restrictions in Title
finally, WikiPage::doUpdateRestrictions. This needs breaking up. At least the actual interaction with the page_restrictions should be done in PermissionManager. Insertion of the dummy revision should probably stay in WikiPagec for now.

The old methods should be deprecated but kept, delegating any calls to the new service.

Considerations:

RestrictionStore should bind to PageIdentity instead of Tilte, once PageIdentity identity becomes available (see T208776). Until then, taking a Title object as input is acceptable, but it must only be used to obtain the page ID or the title text and namespace.
RestrictionStore must not make use of the User class.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Title: restore behavior of getCascadeStrictionSources	mediawiki/core	master	+7 -10
New RestrictionStore service	mediawiki/core	master	+2 K -469
Add more end-to-end tests related to page protection	mediawiki/core	master	+96 -0
Adds DeprecationHelper trait support for the UpdateRepoHookHandlersTest	mediawiki/extensions/Wikibase	master	+7 -1
Adds missing PHPUnit tests for the following Title methods:	mediawiki/core	master	+325 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T208764 Remove cyclic dependency between Title and User classes
		Resolved		Peter.ovchyn	T218395 Create RestrictionStore service

Event Timeline

daniel created this task.Mar 15 2019, 12:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2019, 12:23 PM

daniel removed daniel as the assignee of this task.Mar 15 2019, 4:21 PM

• CCicalese_WMF edited projects, added Platform Team Legacy (Watching / External); removed Platform Team Legacy (Next).Mar 15 2019, 5:38 PM

• CCicalese_WMF edited projects, added Platform Engineering (Decoupling (CDP2)); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).

• CCicalese_WMF triaged this task as Medium priority.Mar 15 2019, 5:41 PM

• CCicalese_WMF edited projects, added Platform Team Workboards (Contractor - Ready); removed Platform Team Legacy (Watching / External), MediaWiki-Decoupling (MediaWiki-Decoupling 2019 Q3/Q4).Mar 26 2019, 4:36 PM

daniel updated the task description. (Show Details)Apr 9 2019, 9:29 AM

daniel mentioned this in T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.

Tgr subscribed.Apr 9 2019, 3:46 PM

dmaza subscribed.Apr 9 2019, 4:27 PM

PageIdentity refers to a page that exists; protecting non-existing pages is entirely meaningful. Also you need to deal with conterfactual state for permission checks. E.g. a permission check for moving a page into the MediaWiki namespace (which has a magic restriction) needs to check against the future state of the page. (This comes up elsewhere as well, e.g. permission checks for a content model change. Probably worth thinking about as a general issue.) So something like TitleValue seems more appropriate here.

The is* methods don't really belong to a storage layer class IMO.

PageIdentity refers to a page that exists; protecting non-existing pages is entirely meaningful.

That's still an open question. It would be nice, but it would be incompatible with Title, making the transition tricky. See discussion at T208776.

• WDoranWMF moved this task from Contractor - Ready to S&F Workboard on the Platform Team Workboards board.Jul 5 2019, 4:54 PM

• WDoranWMF edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (Contractor - Ready).

• WDoranWMF moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Jul 5 2019, 4:57 PM

• WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:56 PM

• WDoranWMF edited projects, added Core Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).

daniel updated the task description. (Show Details)Oct 11 2019, 9:06 AM

tosfos subscribed.Oct 28 2019, 7:56 PM

Vedmaka claimed this task.Nov 1 2019, 1:37 PM

Change 549596 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/core@master] Adds missing PHPUnit tests for the following Title methods:

https://gerrit.wikimedia.org/r/549596

gerritbot added a project: Patch-For-Review.Nov 7 2019, 7:07 PM

• CCicalese_WMF moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Nov 7 2019, 9:44 PM

Change 549596 merged by jenkins-bot:
[mediawiki/core@master] Adds missing PHPUnit tests for the following Title methods:

https://gerrit.wikimedia.org/r/549596

Change 549909 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/core@master] Creates RestrictionStore service

https://gerrit.wikimedia.org/r/549909

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 8 2019, 7:00 PM

• kchapman edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (S&F Workboard).Nov 19 2019, 8:43 PM

• kchapman moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.

• mobrovac moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Dec 10 2019, 12:47 PM

Change 568554 had a related patch set uploaded (by Vedmaka Wakalaka; owner: Vedmaka Wakalaka):
[mediawiki/extensions/Wikibase@master] Adds DeprecationHelper trait support for the UpdateRepoHookHandlersTest

https://gerrit.wikimedia.org/r/568554

Change 568554 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Adds DeprecationHelper trait support for the UpdateRepoHookHandlersTest

https://gerrit.wikimedia.org/r/568554

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Feb 3 2020, 6:00 PM

• WDoranWMF moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:49 PM

Daimona subscribed.Mar 7 2020, 11:27 AM

daniel moved this task from External Code Review Completed to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Apr 16 2020, 12:49 PM

• CCicalese_WMF moved this task from Backlog to Later on the Platform Team Workboards (Clinic Duty Team) board.May 21 2020, 1:51 PM

@Vedmaka are you still working on this?

• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).Mar 23 2021, 2:00 PM