Page MenuHomePhabricator

Add "multiple" attribute support to SelectFileWidget/SelectFileInputWidget
Closed, ResolvedPublic

Description

Acceptance criteria
  • Adding support for multiple to SelectFileWidget/SelectFileInputWidget
  • Provide user feedback about ability to add multiple files to widget

Event Timeline

Change 496901 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] WIP: Support multiple files

https://gerrit.wikimedia.org/r/496901

Change 496901 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Support multiple files

https://gerrit.wikimedia.org/r/496901

Volker_E triaged this task as Medium priority.Mar 20 2019, 3:48 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.

Change 496901 merged by jenkins-bot:
[oojs/ui@master] Support multiple files

https://gerrit.wikimedia.org/r/496901

Missing any feedback for the user in current state on which files are selected, when there are more than input space provides:

image.png (130×1 px, 26 KB)

A tooltip at bare minimum…?!

Change 501429 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.31.3

https://gerrit.wikimedia.org/r/501429

Change 501429 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.3

https://gerrit.wikimedia.org/r/501429

The original feature landed in MediaWiki in the 1.33.0-wmf.25 alpha branch, and so will be on Wikimedia production from 2019-04-09.

Yes, we could take the browser approach of changing the message to "N files", or combine that with the concatenated list.

@Esanders That bug's still waiting for above user feedback to be closed, would you care about it?

Volker_E updated the task description. (Show Details)
Volker_E moved this task from Reviewing to Backlog on the OOUI board.
Volker_E removed a subscriber: gerritbot.
matmarex subscribed.

This has been resolved since 2019. If anyone wants to make design changes, that can happen in another task.