Ship unminified sources when ResourceLoader's debug mode is enabled
Open, Stalled, MediumPublic
Actions

Assigned To

None

Authored By

	• Niedzielski
	Mar 15 2019, 4:46 PM

Description

Popups presently supplies a sourcemap for production debugging. This in itself is useful but unminified sources are preferable since the optimizer may alter the path of execution. This task encompasses the work to continue to ship production sources + sourcemap normally and, only when ResourceLoader's debug mode is enabled, ship unminified sources.

Acceptance criteria

Visiting a page with debug=1 loads the unminified sources
Visiting a page normally continues to load the minified sources

Details

	Subject	Repo	Branch	Lines +/-
	Build: use unminified outputs when debug=1	mediawiki/extensions/Popups	master	+6 K -281

Customize query in gerrit

Related Objects

Mentioned In: T199004: RFC: Add a frontend build step to skins/extensions to our deploy process

Event Timeline

• Niedzielski created this task.Mar 15 2019, 4:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2019, 4:46 PM

Change 496825 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/Popups@master] Build: use unminified outputs when debug=1

https://gerrit.wikimedia.org/r/496825

gerritbot added a project: Patch-For-Review.Mar 15 2019, 4:47 PM

• Niedzielski mentioned this in T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.Mar 15 2019, 4:50 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Mar 15 2019, 6:38 PM

matmarex awarded a token.Mar 15 2019, 7:10 PM

matmarex subscribed.

Proposal looks good to me. I am guessing the additional assets are not a problem given we have to commit them anyway and it sounds like it would help developers debug quicker. Given there's a patch it would be nice to get an estimation of risk for this one!