| Tsevener | |
| Mar 15 2019, 7:17 PM |
| F28513418: IMG_0129.PNG | |
| Mar 29 2019, 11:44 PM |
| F28513416: IMG_0128.PNG | |
| Mar 29 2019, 11:44 PM |
| F28513417: IMG_0131.PNG | |
| Mar 29 2019, 11:44 PM |
| F28513392: IMG_0133.PNG | |
| Mar 29 2019, 11:44 PM |
| F28513413: IMG_0127.PNG | |
| Mar 29 2019, 11:44 PM |
| F28513419: IMG_0132.PNG | |
| Mar 29 2019, 11:44 PM |
New strings for this feature still need to be localized and accessibility labels added to the controls.
The new find & replace navigation bar might need to be reworked to be accessible via Voice Over.
Test the new find & replace bar with dynamic text scaling as well. Right now it may not handle gracefully if that font scales up.
Needs to be checked on RTL languages too.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tsevener | T215955 As an editor when I find some wikitext, I also want to be able to replace and replace all | |||
| Resolved | • JMinor | T218425 Localize and make accessible new strings & controls |
Testing on 6.2.1 (1594)
Everything looked pretty good with dynamic text sizing. VoiceOver worked for the most part but I found that portions of the background article are 'tappable' when looking at the editing onboarding screens. For the below example, the box is the VoiceOver area and it, in this case, it speaks a portion of the background article.
I also tried some editing Hebrew for RTL, there are a few strings yet to be translated
Moving to blocked or waiting for now. I imagine we can break this into smaller tickets as well. Let me know :)
I'm unable to reproduce the tappable background on the edit onboarding screens. I tested on iPad/iPhone develop branches and 1594 TestFlight builds. Unassigning myself in case someone else is able to repro.
Could no longer reproduce the issue with Voice Over on 6.2.1 (1594)
I imagine the strings translation is coming soon :)