Page MenuHomePhabricator

Upgrade various Toolforge infrastructure scripts from Python 2 to Python 3
Closed, ResolvedPublic

Description

See also T218426: Upgrade various Cloud VPS Python 2 scripts to Python 3

modules/profile/files/toolforge/clush/tools-clush-generator:#!/usr/bin/python
modules/profile/files/toolforge/clush/tools-clush-interpreter:#!/usr/bin/python
modules/profile/files/toolforge/gridscripts/runninggridjobsmail.py:#!/usr/bin/python
modules/profile/files/toolforge/gridscripts/runninggridtasks.py:#!/usr/bin/python
modules/profile/files/toolforge/portgrabber:#!/usr/bin/python
modules/profile/files/toolforge/portreleaser:#!/usr/bin/python
modules/profile/files/toolforge/services/updatetools:#!/usr/bin/python
modules/role/files/toollabs/clush/tools-clush-generator:#!/usr/bin/python
modules/role/files/toollabs/clush/tools-clush-interpreter:#!/usr/bin/python
modules/toollabs/files/gridscripts/runninggridjobsmail.py:#!/usr/bin/python
modules/toollabs/files/gridscripts/runninggridtasks.py:#!/usr/bin/python
modules/toollabs/files/portgrabber:#!/usr/bin/python
modules/toollabs/files/portreleaser:#!/usr/bin/python

Event Timeline

Change 566491 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/puppet@production] [WIP] toolforge: Port portgrabber related code to Python 3

https://gerrit.wikimedia.org/r/566491

atiro’s source code is a huge mess, but it has some Python2 parts (pinyin.py, pinyin_table.py and pinyin_table_translit.py in the public_html directory; they don’t even have a shebang to make version obvious). As far as I remember, I tried to make it work under Python3 back in October, but didn’t have enough time . I can make another try when I have more time, given that it’s not after the deadline. When will Python2 be decommissioned on Toolforge?

When will Python2 be decommissioned on Toolforge?

This ticket is intended to be about various infrastructure scripts used in the Toolforge environment. We do not currently have a concrete plan and timeline for deprecating Python2 in the runtime space used by individual tools. All of the operating systems we are currently using include Python2, including Buster which will be present in some form in Toolforge into 2022 at least.

@bd808 Thanks, then I don’t have to worry yet. :) The task title would need some rewording, however, so that other tool owners won’t mistakenly come here like me.

bd808 renamed this task from Upgrade various Toolforge Python 2 scripts to Python 3 to Upgrade various Toolforge infrastructure scripts from Python 2 to Python 3.Jan 22 2020, 7:00 PM

Change 567192 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/puppet@production] toolforge: Run clush helpers with Python 3

https://gerrit.wikimedia.org/r/567192

Bstorm triaged this task as Medium priority.Feb 11 2020, 4:35 PM

Change 567192 merged by Bstorm:
[operations/puppet@production] toolforge: Run clush helpers with Python 3

https://gerrit.wikimedia.org/r/567192

taavi claimed this task.
taavi subscribed.

modules/profile/files/toolforge/proxylistener.py is the only thing remaining and that'll be gone when we kill the grid engine. Closing!

Change 566491 abandoned by Majavah:

[operations/puppet@production] toolforge: Port portgrabber related code to Python 3

Reason:

All of this logic is going away in a months!

https://gerrit.wikimedia.org/r/566491