Page MenuHomePhabricator

Remove conflicting section anchors in historical visual diffs
Closed, ResolvedPublic

Description

Example: Vandalism report
I want to take a look into the whole report (downside) so I go to the table of contents and click on "Benutzer:Bwag (erl. )". I land on top of the page in the visual view.

Reproducing like me with visual view.

It would be better to rename and link in the preview, or remove the anchor.

Event Timeline

We recently worked on a related problem with visual diffs within VisualEditor: T212554. I guess we didn't really think about how historical visual diffs are affected.

Oh yeah, I hate the problem described in T212554... Here we have the problem exactly the other way round (but with the table of contents).

Esanders renamed this task from Remove section anchors in visual view to Remove section anchors in historical visual diffs.Mar 20 2019, 12:16 AM
Esanders renamed this task from Remove section anchors in historical visual diffs to Remove conflicting section anchors in historical visual diffs.Mar 20 2019, 12:20 AM

Change 755051 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Remove conflicting section IDs in diff views

https://gerrit.wikimedia.org/r/755051

Change 755051 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove conflicting section IDs in diff views

https://gerrit.wikimedia.org/r/755051

Clicking on the section to which change was made in the table of contents - "Benutzer:Bwag (erl. )" in this case, takes user to the corresponding preview section below the table of content; just as the other links behave.
See:

Screenshot 2022-01-29 at 04.02.32.png (1×3 px, 994 KB)
and https://photos.app.goo.gl/vNqmrq4Dyy7kHG2K6

Kindly note that content was copied mainly for testing purposes and was deleted immediately after.

ppelberg claimed this task.