Page MenuHomePhabricator

PageTriage's ArticleCompileProcessor::getLastEditTimestamp() will never query from master properly
Closed, ResolvedPublic

Description

		// TODO deduplicate with ArticleCompileInterface::getArticleByPageId(), maybe move to this class
		// FIXME: this will never be true because componentDb is an array
		// @phan-suppress-next-line PhanTypeComparisonFromArray
		$fromdb = $this->componentDb === DB_MASTER ? 'fromdbmaster' : 'fromdb';

Except $this->componentDb is an array, and will never be equal to DB_MASTER.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 497299 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] Check BasicData component to determine db query source

https://gerrit.wikimedia.org/r/497299

Change 497299 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Check BasicData component to determine db query source

https://gerrit.wikimedia.org/r/497299