Page MenuHomePhabricator
Create Task
Maniphest T218513

TypeError: this.setFlags is not a function preventing datetime fields from being loaded
Closed, ResolvedPublic
Actions

Description

While testing some new AbuseFilter features on Beta Cluster, I noticed that something in OOUI 0.31 is causing the error in the title. Specifically, if you head to https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:AbuseFilter/test, you'll see that the form is missing a field ("Changes made after:") and the following ("Changes made before:") isn't fully initialized. Both of these are datetime fields, and this is what's logged in the console:

TypeError: this.setFlags is not a function
    at MwWidgetsDatetimeDateTimeInputWidget.mw.widgets.datetime.DateTimeInputWidget.updateFieldsFromValue (<anonymous>:135:308)
    at MwWidgetsDatetimeDateTimeInputWidget.mw.widgets.datetime.DateTimeInputWidget.setupFields (<anonymous>:134:738)
    at new MwWidgetsDatetimeDateTimeInputWidget (<anonymous>:129:479)
    at Object.OO.ui.Element.static.unsafeInfuse (load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0gwg1ug:160)
    at deserialize (load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0gwg1ug:160)
    at Object.oo.copy (<anonymous>:76:635)
    at Object.oo.copy (<anonymous>:77:162)
    at Object.OO.ui.Element.static.unsafeInfuse (load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0gwg1ug:160)
    at Object.OO.ui.Element.static.infuse (load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0gwg1ug:158)
    at Object.OO.ui.infuse (load.php?debug=false&lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0gwg1ug:154)

I tested this on my local wiki with core+OOUI ~2 weeks old and it didn't happen, so I guessed that this comes from OOUI 0.31.

Details

SubjectRepoBranchLines +/-
Mixin FlaggedElement to DateTimeInputWidgetmediawiki/coremaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Mar 17 2019, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2019, 3:01 PM
Daimona triaged this task as High priority.Mar 17 2019, 3:02 PM
Daimona added a parent task: T206676: 1.33.0-wmf.22 deployment blockers.

Train blocker because this hides form fields, high prio because there's time to fix it before the train starts.

Daimona renamed this task from TypeError: this.setFlags is not a function preventing fields from being loaded to TypeError: this.setFlags is not a function preventing datetime fields from being loaded.Mar 17 2019, 3:02 PM
zeljkofilipin raised the priority of this task from High to Unbreak Now!.Mar 18 2019, 9:31 AM
zeljkofilipin subscribed.

Train blockers are Unbreak Now!.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 18 2019, 9:31 AM
Daimona added a comment.Mar 18 2019, 9:33 AM
In T218513#5031670, @zeljkofilipin wrote:

Train blockers are Unbreak Now!.

I chose high because there was some time to fix it before train, but actually yes, this should be UBN. Of note, I confirm that this really happens for every datetime field, for instance on Special:Block.

Mainframe98 subscribed.Mar 18 2019, 9:34 AM
zeljkofilipin added a comment.Mar 18 2019, 10:04 AM

It was high last week, it's UBN! this week. 😄

Daimona added a comment.Mar 18 2019, 10:05 AM

A quick look points at https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/495296/, since setFlags is a method defined in the FlaggedElement class.

EDIT (after writing the above): yep, coming with a fix.

gerritbot subscribed.Mar 18 2019, 10:08 AM

Change 497260 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Mixin FlaggedElement to DateTimeInputWidget

https://gerrit.wikimedia.org/r/497260

gerritbot added a project: Patch-For-Review.Mar 18 2019, 10:08 AM
Daimona claimed this task.Mar 18 2019, 10:10 AM
Daimona merged a task: T218322: Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019).Mar 18 2019, 10:19 AM
Daimona added subscribers: • TBolliger, MGChecker, Etonkovidova.
zeljkofilipin added a comment.Mar 18 2019, 12:07 PM

@Daimona 497260 should fix the problem?

Daimona added a comment.Mar 18 2019, 12:19 PM

@zeljkofilipin Yes, it does. And I can also confirm that DateTime is the only input type affected by this bug.

zeljkofilipin added a comment.Mar 18 2019, 12:25 PM

Thanks. I've left a comment in Gerrit that that patch is related to train blocker. It should speed up the review.

gerritbot added a comment.Mar 18 2019, 9:26 PM

Change 497260 merged by jenkins-bot:
[mediawiki/core@master] Mixin FlaggedElement to DateTimeInputWidget

https://gerrit.wikimedia.org/r/497260

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 18 2019, 10:01 PM
Jdforrester-WMF closed this task as Resolved.Mar 18 2019, 10:05 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Fixed in master. No back-port needed.

Liuxinyu970226 unsubscribed.Mar 19 2019, 10:36 AM
zeljkofilipin awarded a token.Mar 19 2019, 11:12 AM
Volker_E subscribed.Apr 27 2019, 8:09 AM

Belated thanks @Daimona! :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL