Page MenuHomePhabricator
Create Task
Maniphest T218554

Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

https://www.mediawiki.org/wiki/Manual:Block_and_unblock#URL_parameters probably needs an update after the introduction of partial blocks. For example, passing wpCreateAccount via an URL such as https://meta.wikimedia.org/w/index.php?title=Special:Block&wpTarget=Example~metawiki&wpExpiry=infinite&wpHardBlock=0&wpAutoBlock=0&wpCreateAccount=0&wpReason=other&wpReason-other=Test will have the "account creation" checkbox marked despite wpCreateAccount=0. I checked SpecialBlock.php but CreateAccount is still called as such, thus no idea how to fix this.

Another question is to document if it is possible to pass URL parameters to perform partial blocks, its options, etc.

Thank you.

Details

SubjectRepoBranchLines +/-
Fix wpCreateAccount bug when set on Special:Block url paramsmediawiki/coremaster+5 -17
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Mar 18 2019, 10:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 10:52 AM
MarcoAurelio moved this task from Backlog to User blocking on the MediaWiki-User-management board.Mar 18 2019, 10:52 AM
MarcoAurelio moved this task from Backlog to Update or Improvement Needed to Existing Technical Documentation on the Documentation board.
MarcoAurelio mentioned this in T218626: [Epic] Partial block rollout.Mar 19 2019, 10:27 AM
Tchanders added a project: Anti-Harassment.Mar 19 2019, 2:34 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptMar 19 2019, 2:34 PM
Tchanders mentioned this in T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.Mar 22 2019, 5:44 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Mar 25 2019, 5:08 PM
• Niharika triaged this task as Medium priority.Mar 27 2019, 7:05 PM
• Niharika set the point value for this task to 2.
• Niharika moved this task from Triage/To be Estimated to Zayin - ז on the Anti-Harassment board.
• Niharika edited projects, added Anti-Harassment (Zayin - ז); removed Anti-Harassment.
dmaza claimed this task.Apr 1 2019, 8:07 PM
dmaza moved this task from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
gerritbot added a comment.Apr 2 2019, 6:11 PM

Change 500802 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Fix wpCreateAccount bug when set on Special:Block url params

https://gerrit.wikimedia.org/r/500802

gerritbot added a project: Patch-For-Review.Apr 2 2019, 6:11 PM
dmaza moved this task from In Progress to Review on the Anti-Harassment (Zayin - ז) board.Apr 3 2019, 7:42 PM
Tchanders moved this task from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.Apr 4 2019, 12:54 PM
gerritbot added a comment.Apr 4 2019, 12:58 PM

Change 500802 merged by jenkins-bot:
[mediawiki/core@master] Fix wpCreateAccount bug when set on Special:Block url params

https://gerrit.wikimedia.org/r/500802

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 4 2019, 1:01 PM
Tchanders subscribed.EditedApr 4 2019, 1:07 PM

NB this problem is specific to wpCreateAccount - the fix makes sure we don't override the status of the "Account creation" checkbox if the wpCreateAccount parameter is present.

Tchanders renamed this task from Update URL block parameters after partial blocks to Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param.Apr 4 2019, 1:11 PM
Tchanders added a comment.Apr 4 2019, 1:40 PM

@MarcoAurelio We have documented the partial blocks params wpEditingRestriction, wpPageRestrictions and wpNamespaceRestrictions at https://www.mediawiki.org/wiki/Manual:Block_and_unblock

dom_walden moved this task from QA/Testing to Done on the Anti-Harassment (Zayin - ז) board.Apr 7 2019, 6:34 PM
dom_walden subscribed.

If wpCreateAccount is set in the url, then "Block account creation" will be checked/unchecked as appropriate and not change when toggling.

Otherwise, the behaviour of "Block account creation" checkbox as it was before: it changes when you toggle between sitewide and partial, unless editing a block or resubmitting the form.

All the parameters in https://www.mediawiki.org/wiki/Manual:Block_and_unblock#URL_parameters modify the form as appropriate, including when not using JS.

Environment:
https://en.wikipedia.beta.wmflabs.or
MediaWiki 1.33.0-alpha (a38af7b) 17:25, 7 April 2019

• Niharika closed this task as Resolved.Apr 8 2019, 5:50 PM
• Niharika subscribed.

Thank you, @dom_walden!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL