Page MenuHomePhabricator

Some messages in the Citoid extension have translated 'www.example.com' into another language
Closed, ResolvedPublic

Description

The 'www.example.com' has been translated in at least one instance to point to a url that is a spam domain, in the file /i18n/jv.json

However, www.example.com is a reserved domain intended for this purpose (as a placeholder) and should not be translated.

All messages should be checked to see if this has happened in any of them and fixed if not (i.e. changed to www.example.com) and a note should be made in /i18n/qqq.json informing translators not to translate this domain name.

More info:
https://www.mediawiki.org/wiki/Localisation
https://www.mediawiki.org/wiki/Localisation_file_format

Event Timeline

Mvolz created this task.Mar 18 2019, 12:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 12:23 PM
Mvolz updated the task description. (Show Details)Mar 18 2019, 12:25 PM
Mvolz triaged this task as Low priority.
Mvolz renamed this task from Some messages in the citoid extension have translated 'www.example.com' into another language to Some messages in the Citoid extension have translated 'www.example.com' into another language.
Mvolz updated the task description. (Show Details)
Mvolz updated the task description. (Show Details)
Mvolz updated the task description. (Show Details)Mar 18 2019, 12:29 PM
Mvolz updated the task description. (Show Details)Mar 18 2019, 12:33 PM
Mvolz moved this task from Backlog to Extension on the Citoid board.Mar 18 2019, 12:50 PM
Nikitrain added a subscriber: Nikitrain.EditedMar 29 2019, 11:18 AM

I am interested in this task. One query, Where should the Note be included, in the beginning, end or someplace else?

I am interested in this task. One query, Where should the Note be included, in the beginning, end or someplace else?

The end would probably be fine!

Seeing the jv.json file on git hub. I noticed that file contain
"citoid-citefromiddialog-search-placeholder": "conto http://www.example.com",
instead of
"citoid-citefromiddialog-search-placeholder": "http://www.example.com",
Is this how this is needed to be fixed?

Mvolz added a comment.EditedMar 29 2019, 11:35 AM

Seeing the jv.json file on git hub. I noticed that file contain
"citoid-citefromiddialog-search-placeholder": "conto http://www.example.com",
instead of
"citoid-citefromiddialog-search-placeholder": "http://www.example.com",
Is this how this is needed to be fixed?

Oh. it looks like someone already fixed it! In that case just the qqq message needs to be fixed.

Mvolz added a comment.EditedMar 29 2019, 11:42 AM

Seeing the jv.json file on git hub. I noticed that file contain
"citoid-citefromiddialog-search-placeholder": "conto http://www.example.com",
instead of
"citoid-citefromiddialog-search-placeholder": "http://www.example.com",
Is this how this is needed to be fixed?

Oh. it looks like someone already fixed it! In that case just the qqq message needs to be fixed.

Yes, it was fixed here: https://github.com/wikimedia/mediawiki-extensions-Citoid/commit/3076aa0cac858bc55e58edd546312d21c28065c7#diff-2c8d2b40d34c3d5af8a16b44804bca41

(it used to say conto.com)

Nikitrain added a comment.EditedMar 29 2019, 11:46 AM

@Mvolz I have opened a pull request.
and include this note at the end of the qqq.json file
/*
Note for translators: Do not translate the search-placeholder domain name ("http://www.example.com").
http://www.example.com is a reserved domain intended to be used as a placeholder and should not be translated.
*/

@Mvolz I have opened a pull request.
and include this note at the end of the qqq.json file
/*
Note for translators: Do not translate the search-placeholder domain name ("http://www.example.com").
http://www.example.com is a reserved domain intended to be used as a placeholder and should not be translated.
*/

It should go in the message in qqq, not as a comment. But the text is fine (although you don't need the note for translators bit as this is implied, since qqq is basically a file with notes for translators!)

@Mvolz I have opened a pull request.
and include this note at the end of the qqq.json file
/*
Note for translators: Do not translate the search-placeholder domain name ("http://www.example.com").
http://www.example.com is a reserved domain intended to be used as a placeholder and should not be translated.
*/

Thanks for the feedback! on it ! is anything else needed to be done other than this?
It should go in the message in qqq, not as a comment. But the text is fine (although you don't need the note for translators bit as this is implied, since qqq is basically a file with notes for translators!)

@Mvolz I have opened a pull request.
and include this note at the end of the qqq.json file
/*
Note for translators: Do not translate the search-placeholder domain name ("http://www.example.com").
http://www.example.com is a reserved domain intended to be used as a placeholder and should not be translated.
*/

Thanks for the feedback! on it ! is anything else needed to be done other than this?
It should go in the message in qqq, not as a comment. But the text is fine (although you don't need the note for translators bit as this is implied, since qqq is basically a file with notes for translators!)

The change needs to be submitted in gerrit: see

https://www.mediawiki.org/wiki/Gerrit

and

https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr

when I see qqq.json it already has
"citoid-citefromiddialog-search-placeholder": "{{doc-important|Do not translate example.com as it is a domain name specifically reserved by IANA for examples.}}\n\nPlaceholder for the URL/DOI/PMCID/PMID/ISBN search field.",
Should I still edit the message.

when I see qqq.json it already has
"citoid-citefromiddialog-search-placeholder": "{{doc-important|Do not translate example.com as it is a domain name specifically reserved by IANA for examples.}}\n\nPlaceholder for the URL/DOI/PMCID/PMID/ISBN search field.",
Should I still edit the message.

No I guess not, I guess someone has already done this task, sorry :(

Mvolz closed this task as Resolved.Mar 29 2019, 12:15 PM