Page MenuHomePhabricator

Switch to edit mode
Closed, ResolvedPublic

Description

  • introduce editMode as a state for the termbox
  • add editable versions of the Label, Description, and Aliases components
  • add decorating components to each of Label, Description, and Aliases (or one component switching out all 3 of them)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 1:48 PM

Change 497484 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] WIP Edit-component

https://gerrit.wikimedia.org/r/497484

Hi @Matthias_Geisler_WMDE,

find the specs for Editing fields below:

  • The input filed has the text heights plus 8px padding to each side
  • it is depicte by a 1px inside border in Base50
  • it has 2px radiuses
  • between text fields we have 8px padding
  • it contains placeholder text when no input exists (see specs for that in the parent task)
  • the input field allows line breaks and adjusts in heights according to that
  • the input field spans over the defined width of the "content" column

There are currently no valid mocks. But I hope this screenshot helps to get a better understanding of the written above:

Change 498060 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce edit mode

https://gerrit.wikimedia.org/r/498060

Change 497484 abandoned by Matthias Geisler:
Introduce edit mode

Reason:
redirected to https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/ /498060/

https://gerrit.wikimedia.org/r/497484

Change 498805 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Alternative EditMode Model

https://gerrit.wikimedia.org/r/498805

Change 499040 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce EditMode to store

https://gerrit.wikimedia.org/r/499040

Change 499043 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Introduce edit-label, -descriptions and -aliases

https://gerrit.wikimedia.org/r/499043

Change 498060 abandoned by Matthias Geisler:
Introduce edit mode

Reason:
Is replaced by https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/ /499040/ and followers

https://gerrit.wikimedia.org/r/498060

Change 498805 abandoned by Matthias Geisler:
Alternative EditMode Model

Reason:
replaced by https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/ /499040/ and followers

https://gerrit.wikimedia.org/r/498805

Change 499040 merged by jenkins-bot:
[wikibase/termbox@master] Introduce EditMode to store

https://gerrit.wikimedia.org/r/499040

Change 499574 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Click events (switch to editmode from remode)

https://gerrit.wikimedia.org/r/499574

Change 499986 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Slot bases editmode switching

https://gerrit.wikimedia.org/r/499986

Change 499043 merged by jenkins-bot:
[wikibase/termbox@master] Introduce edit-label, -descriptions and -aliases

https://gerrit.wikimedia.org/r/499043

Change 499574 merged by jenkins-bot:
[wikibase/termbox@master] TermBox: Connect EditTools events and store actions

https://gerrit.wikimedia.org/r/499574

Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:38 AM