Add the publish button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Mar 18 2019, 1:49 PM

Description

add the asset
add the button component
add a decorating component showing either save or edit depending on edit mode

Use this asset to visualize the save action, please

white_checkmark_on_blue_circle.svg407 BDownload

Details

	Subject	Repo	Branch	Lines +/-
	Publish changes: add button and first shy use of it	wikibase/termbox	master	+188 -29

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T215515 Termbox Editing Mode
Open	None	T215522 Switch from reading into editing mode
Resolved	• Lea_WMDE	T216987 Allow editing of fields
Resolved	• Pablo-WMDE	T218573 Add the publish button

Event Timeline

Jakob_WMDE created this task.Mar 18 2019, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 1:49 PM

Jakob_WMDE renamed this task from Add the save button icon asset to Add the save button.Mar 18 2019, 2:19 PM

Jakob_WMDE updated the task description. (Show Details)

• Pablo-WMDE edited projects, added Wikidata-Termbox-Iteration-11; removed Wikidata-Termbox.Mar 18 2019, 3:05 PM

• Pablo-WMDE claimed this task.Mar 19 2019, 7:57 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-11 board.

• Hanna_Petruschat_WMDE updated the task description. (Show Details)Mar 19 2019, 10:53 AM

@Hanna_Petruschat_WMDE Thanks for the asset!

@Lea_WMDE In addition to the icons immediately visible we also use messages to explain what buttons do (e.g. screenreaders). As of T161367 there are two "competing" messages for the action of persisting, "save" & "publish". Which one is chosen is configurable per installation. Does this configurability have to be reflected in termbox or can we favor one over the other (i.e. always use "publish" implying that termbox will only every be used on Wikimedia projects)?

@Lea_WMDE In addition to the icons immediately visible we also use messages to explain what buttons do (e.g. screenreaders). As of T161367 there are two "competing" messages for the action of persisting, "save" & "publish". Which one is chosen is configurable per installation. Does this configurability have to be reflected in termbox or can we favor one over the other (i.e. always use "publish" implying that termbox will only every be used on Wikimedia projects)?

Just publish sounds best to me, even when it is not configurable I would assume other project could live with the "publish" wording as well :)

• Pablo-WMDE renamed this task from Add the save button to Add the publish button.Mar 19 2019, 1:27 PM

Change 497539 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] Publish changes: add button and use of it

https://gerrit.wikimedia.org/r/497539

gerritbot added a project: Patch-For-Review.Mar 19 2019, 4:19 PM

• Pablo-WMDE added subscribers: WMDE-leszek, Addshore.Mar 21 2019, 7:12 PM

This comment was removed by • Pablo-WMDE.

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-11 board.Mar 22 2019, 10:03 AM

• Pablo-WMDE added a project: Wikidata-Termbox-Iteration-12-OLD.Mar 25 2019, 11:38 AM

• Pablo-WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-12-OLD board.

• Pablo-WMDE added a project: Wikidata-Termbox-Iteration-12 ✓.Mar 25 2019, 3:12 PM

• Pablo-WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-12 ✓ board.

• Pablo-WMDE removed a project: Wikidata-Termbox-Iteration-12-OLD.Mar 25 2019, 6:18 PM

Change 497539 merged by jenkins-bot:
[wikibase/termbox@master] Publish changes: add button and first shy use of it

https://gerrit.wikimedia.org/r/497539